Skip to content

Commit 9ea2b6c

Browse files
authored
Merge pull request #24 from magus424/update-exception-handling
Update Exception handling to include previous Exception.
2 parents 0c2f2b0 + 13819c2 commit 9ea2b6c

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

src/RecommApi/Client.php

+6-6
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* Client for easy usage of Recombee recommendation API
1616
*/
1717
class Client{
18-
18+
1919
protected $account;
2020
protected $token;
2121
protected $request;
@@ -72,7 +72,7 @@ protected function getUserAgent() {
7272
* @throws Exceptions\ApiTimeoutException ApiTimeoutException if the request takes too long
7373
*/
7474
public function send(Requests\Request $request) {
75-
75+
7676
if($request instanceof Requests\Batch && count($request->requests) > Client::BATCH_MAX_SIZE)
7777
return $this->sendMultipartBatch($request);
7878

@@ -108,12 +108,12 @@ public function send(Requests\Request $request) {
108108
}
109109
catch(\GuzzleHttp\Exception\ConnectException $e)
110110
{
111-
throw new ApiTimeoutException($request);
111+
throw new ApiTimeoutException($request, $e);
112112
}
113113
catch(\GuzzleHttp\Exception\GuzzleException $e)
114114
{
115-
if(strpos($e->getMessage(), 'cURL error 28') !== false) throw new ApiTimeoutException($request);
116-
if(strpos($e->getMessage(), 'timed out') !== false) throw new ApiTimeoutException($request);
115+
if(strpos($e->getMessage(), 'cURL error 28') !== false) throw new ApiTimeoutException($request, $e);
116+
if(strpos($e->getMessage(), 'timed out') !== false) throw new ApiTimeoutException($request, $e);
117117

118118
throw $e;
119119
}
@@ -129,7 +129,7 @@ protected function getOptionalHttpHeaders() {
129129
}
130130

131131
protected function getHttpHeaders() {
132-
return array_merge(array('User-Agent' => $this->user_agent), $this->getOptionalHttpHeaders());
132+
return array_merge(array('User-Agent' => $this->user_agent), $this->getOptionalHttpHeaders());
133133
}
134134

135135
protected function getRequestOptions() {

src/RecommApi/Exceptions/ApiTimeoutException.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ class ApiTimeoutException extends ApiException{
1717
*/
1818
public $request;
1919

20-
public function __construct($request, Exception $previous = null) {
20+
public function __construct($request, \Exception $previous = null) {
2121
$this->request = $request;
2222
$description = "Client did not get response within #{$request->getTimeout()} ms";
2323
parent::__construct($description, 28, $previous);

src/RecommApi/Exceptions/ResponseException.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class ResponseException extends ApiException{
2525
*/
2626
public $description;
2727

28-
public function __construct($request, $status_code, $description, Exception $previous = null) {
28+
public function __construct($request, $status_code, $description, \Exception $previous = null) {
2929
$this->request = $request;
3030
$this->status_code = $status_code;
3131
$this->description = $description;

src/RecommApi/Exceptions/UnknownOptionalParameterException.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ class UnknownOptionalParameterException extends \InvalidArgumentException {
1515

1616
/**
1717
* @var string $parameter Given invalid name
18-
*/
18+
*/
1919
public $parameter;
2020

21-
public function __construct($par, Exception $previous = null) {
21+
public function __construct($par, \Exception $previous = null) {
2222
$this->parameter = $par;
2323
parent::__construct("Unknown parameter {$this->parameter} was given to the request", 0, $previous);
2424
}

0 commit comments

Comments
 (0)