fix: address PR review comments

Signed-off-by: Ondrej Dockal <[email protected]>

Author: odockal

Diff for: .github/workflows/e2e-main.yaml

@@ -145,11 +145,11 @@ jobs:
           jq --arg version "$version" '.devDependencies."@podman-desktop/tests-playwright" = $version' package.json > package.json_tmp && mv package.json_tmp package.json
           pnpm install --no-frozen-lockfile
 
-      - name: Set default browser
+      - name: Set default browser to Chromium
         run: |
+          # TODO: Follow up issue: https://github.com/redhat-developer/podman-desktop-redhat-account-ext/issues/727
           chromiumBrowser=$(which chromium-browser)
           echo "Path to chromium: ${chromiumBrowser}"
-          # xdg-settings set default-web-browser chromium-browser.desktop
           sudo update-alternatives --install /usr/bin/x-www-browser x-www-browser $chromiumBrowser 500
           sudo update-alternatives --set x-www-browser $chromiumBrowser
 

Diff for: tests/src/model/pages/sso-authentication-page.ts

@@ -67,4 +67,4 @@ export class SSOAuthenticationProviderCardPage extends BasePage {
             await playExpect(this.providerStatus).toContainText(loggedIn ? 'logged in' : 'logged out', { ignoreCase: true });
         });
     }
-}
+}

Diff for: tests/src/sso-extension.spec.ts

@@ -69,7 +69,7 @@ test.afterAll(async ({ runner }) => {
     if (browser) {
       await browser.close();
     }
-  } catch (error) {
+  } catch (error: unknown) {
     console.log(`Something went wrong when closing browser: ${error}`);
   } finally {
     await terminateExternalBrowser();
@@ -276,7 +276,7 @@ export async function terminateExternalBrowser(): Promise<void> {
     try {
       // eslint-disable-next-line
       execSync('pkill -o firefox');
-    } catch (error) {
+    } catch (error: unknown) {
       console.log(`Error while killing the firefox: ${error}`);
     }
   }

Diff for: tests/src/utility/auth-utils.ts

@@ -82,7 +82,7 @@ export async function findPageWithTitleInBrowser(browser: Browser, expectedTitle
     // Connect to the same Chrome instance via CDP
     // possible option is to use chromium.connectOverCDP(`http://localhost:${port}`);
     if (!browserLaunch) {
-      throw Error('Browser object was not initialized properly');
+      throw new Error('Browser object was not initialized properly');
     } else {
       console.log(`Browser connected: ${browserLaunch.isConnected()}`);
     }
@@ -109,6 +109,3 @@ export async function findPageWithTitleInBrowser(browser: Browser, expectedTitle
     console.log(`Matched string: ${urlMatch}`);
     return urlMatch;
   }
-  
-
-