Skip to content

[🚀 Request] Expose more configuration for selenium-webdriver ServiceBuilder #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmingles opened this issue Feb 28, 2025 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@bmingles
Copy link

bmingles commented Feb 28, 2025

Describe the request

The instantiation of the selenium-webdriver/chrome ServiceBuilder is currently encapsulated in the VSBrowser.start function. It would be nice to expose some of its configuration options, specifically ones related to logging.

For example, the setStdio and enableVerboseLogging methods can be helpful for diagnosing root causes of errors that currently get swallowed:

const serviceBuilder = new ServiceBuilder(chromeDriverBinaryPath);

// Setting this allows logging to make it to stdio of process running tests
serviceBuilder.setStdio('inherit');

// Provides more detailed logging if needed
serviceBuilder.enableVerboseLogging();

this._driver = await new page_objects_1.Builder()
  .setChromeService(serviceBuilder)
  .forBrowser(page_objects_1.Browser.CHROME)
  .setChromeOptions(options)
  .build();

I'm not familiar enough with the architecture to suggest how these might best be exposed, only that having some way to configure the ServiceBuilder would be helpful.

Usage

Enabling more verbose logging was key to being able to identify the root causes of this issue:
#1767

@bmingles bmingles added enhancement New feature or request new-issue New issue which was not discussed yet labels Feb 28, 2025
@alagiribuddhar
Copy link

It would be helpful if chrome driver builder options were configurable both via CLI and via Extester API. In chrome driver we can run driver in headless mode. For running Extester in CI/CD pipeline headless mode would offer better performance than xvfb.
Is there any time line when this feature can be expected.

@djelinek djelinek removed the new-issue New issue which was not discussed yet label Apr 8, 2025
@djelinek djelinek moved this from New to Backlog in ExTester Apr 8, 2025
@djelinek djelinek added this to the Backlog milestone Apr 8, 2025
@djelinek
Copy link
Collaborator

djelinek commented Apr 8, 2025

It would be helpful if chrome driver builder options were configurable both via CLI and via Extester API. In chrome driver we can run driver in headless mode. For running Extester in CI/CD pipeline headless mode would offer better performance than xvfb. Is there any time line when this feature can be expected.

I agree we can expose more options to configure for selenium-webdriver

regarding headless mode, afaik it won't be working for VS Code e2e testing because you cannot run UI tests in headless mode for Electron app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

3 participants