Skip to content

Commit 98793a9

Browse files
[fix] Fixed gh issue 83: redis-benchmark csv exporter parser conversion issues (#84)
1 parent 439b733 commit 98793a9

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[tool.poetry]
22
name = "redisbench-admin"
3-
version = "0.1.65"
3+
version = "0.1.66"
44
description = "Redis benchmark run helper. A wrapper around Redis and Redis Modules benchmark tools ( ftsb_redisearch, memtier_benchmark, redis-benchmark, aibench, etc... )."
55
authors = ["filipecosta90 <[email protected]>"]
66
readme = "README.md"

redisbench_admin/run/redis_benchmark/redis_benchmark.py

+4
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ def redis_benchmark_from_stdout_csv_to_json(
2727
test_name = overload_test_name
2828
results_dict["Tests"][test_name] = {}
2929
for pos, value in enumerate(row[1:]):
30+
if '"' == value[0]:
31+
value = value[1:]
32+
if '"' == value[-1]:
33+
value = value[:-1]
3034
results_dict["Tests"][test_name][header[pos + 1]] = value
3135
return results_dict
3236

tests/test_redis_benchmark_csv_format.py

+5
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,18 @@ def test_redis_benchmark_export_logic():
3131
results_dict = redis_benchmark_from_stdout_csv_to_json(csv_data, 1, "1")
3232
redis_benchmark_export_logic(results_dict, [], None, {})
3333
assert "SET" in results_dict["Tests"]
34+
assert "139082.06" == results_dict["Tests"]["SET"]["rps"]
3435
assert "GET" in results_dict["Tests"]
36+
assert "136986.30" == results_dict["Tests"]["GET"]["rps"]
37+
assert len("136986.30") == len(results_dict["Tests"]["GET"]["rps"])
3538

3639
with open("./tests/test_data/redis-benchmark-6.2.0-csv.out.2", "r") as csv_file:
3740
csv_data = csv_file.read()
3841
results_dict = redis_benchmark_from_stdout_csv_to_json(csv_data, 1, "1")
3942
redis_benchmark_export_logic(results_dict, [], None, {})
4043
assert "JSON.SET" in results_dict["Tests"]
44+
assert "73391.80" == results_dict["Tests"]["JSON.SET"]["rps"]
45+
4146

4247
with open("./tests/test_data/redis-benchmark-6.2.0-csv.out.2", "r") as csv_file:
4348
csv_data = csv_file.read()

0 commit comments

Comments
 (0)