You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been recently working in a non-rails project that makes use of Sidekiq and I'd love to integrate SemanticLogger there. From what I can see however, it seems that there's quite a bit of logic to add proper support for Sidekiq - and it's all within rails_semantic_logger codebase.
What do you think of extracting the Sidekiq related code up to semantic_logger or, perhaps, to a new dedicated gem (e.g.: sidekiq_semantic_logger)? Regardless of where the code might move, rails_semantic_logger could still automatically require it and patch Sidekiq logger so I don't think this would be a breaking change - plus it could make development towards Sidekiq development a bit easier to maintain.
From what I see there wouldn't be many changes involved, only:
Move these to their new destination (semantic_logger or sidekiq_semantic_logger):
Hello @reidmorrison 👋
I've been recently working in a non-rails project that makes use of Sidekiq and I'd love to integrate SemanticLogger there. From what I can see however, it seems that there's quite a bit of logic to add proper support for Sidekiq - and it's all within
rails_semantic_logger
codebase.What do you think of extracting the Sidekiq related code up to
semantic_logger
or, perhaps, to a new dedicated gem (e.g.:sidekiq_semantic_logger
)? Regardless of where the code might move,rails_semantic_logger
could still automatically require it and patch Sidekiq logger so I don't think this would be a breaking change - plus it could make development towards Sidekiq development a bit easier to maintain.From what I see there wouldn't be many changes involved, only:
semantic_logger
orsidekiq_semantic_logger
):lib/rails_semantic_logger/extensions/sidekiq/sidekiq.rb
lib/rails_semantic_logger/sidekiq/defaults.rb
lib/rails_semantic_logger/sidekiq/job_logger.rb
lib/rails_semantic_logger/sidekiq/loggable.rb
::Sidekiq
constant is defined.Let me know your thoughts! I can definitely help if that sounds like a welcome change 😄
The text was updated successfully, but these errors were encountered: