Skip to content

Updates needed for php 8.4 #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
leenooks opened this issue Feb 13, 2025 · 1 comment · May be fixed by #236
Closed

Updates needed for php 8.4 #231

leenooks opened this issue Feb 13, 2025 · 1 comment · May be fixed by #236
Labels
wontfix This will not be worked on

Comments

@leenooks
Copy link

Howdy,

Looks like with php 8.4, your model is throwing some PHP Deprecated messages.

PHP Deprecated:  Rennokki\QueryCache\Traits\QueryCacheModule::getFromQueryCache(): Implicitly marking parameter $id as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/rennokki/laravel-eloquent-query-cache/src/Traits/QueryCacheModule.php on line 72
PHP Deprecated:  Rennokki\QueryCache\Traits\QueryCacheModule::getQueryCacheCallback(): Implicitly marking parameter $id as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/rennokki/laravel-eloquent-query-cache/src/Traits/QueryCacheModule.php on line 98
PHP Deprecated:  Rennokki\QueryCache\Traits\QueryCacheModule::getCacheKey(): Implicitly marking parameter $id as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/rennokki/laravel-eloquent-query-cache/src/Traits/QueryCacheModule.php on line 115
PHP Deprecated:  Rennokki\QueryCache\Traits\QueryCacheModule::getCacheKey(): Implicitly marking parameter $appends as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/rennokki/laravel-eloquent-query-cache/src/Traits/QueryCacheModule.php on line 115
PHP Deprecated:  Rennokki\QueryCache\Traits\QueryCacheModule::generateCacheKey(): Implicitly marking parameter $id as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/rennokki/laravel-eloquent-query-cache/src/Traits/QueryCacheModule.php on line 131
PHP Deprecated:  Rennokki\QueryCache\Traits\QueryCacheModule::generateCacheKey(): Implicitly marking parameter $appends as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/rennokki/laravel-eloquent-query-cache/src/Traits/QueryCacheModule.php on line 131
PHP Deprecated:  Rennokki\QueryCache\Traits\QueryCacheModule::generatePlainCacheKey(): Implicitly marking parameter $id as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/rennokki/laravel-eloquent-query-cache/src/Traits/QueryCacheModule.php on line 150
PHP Deprecated:  Rennokki\QueryCache\Traits\QueryCacheModule::generatePlainCacheKey(): Implicitly marking parameter $appends as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/rennokki/laravel-eloquent-query-cache/src/Traits/QueryCacheModule.php on line 150
PHP Deprecated:  Rennokki\QueryCache\Contracts\QueryCacheModuleInterface::generatePlainCacheKey(): Implicitly marking parameter $id as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/rennokki/laravel-eloquent-query-cache/src/Contracts/QueryCacheModuleInterface.php on line 15
PHP Deprecated:  Rennokki\QueryCache\Contracts\QueryCacheModuleInterface::generatePlainCacheKey(): Implicitly marking parameter $appends as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/rennokki/laravel-eloquent-query-cache/src/Contracts/QueryCacheModuleInterface.php on line 15
PHP Deprecated:  Rennokki\QueryCache\Contracts\QueryCacheModuleInterface::getQueryCacheCallback(): Implicitly marking parameter $id as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/rennokki/laravel-eloquent-query-cache/src/Contracts/QueryCacheModuleInterface.php on line 25
@scottasmith scottasmith mentioned this issue Mar 4, 2025
Closed
@byErikas byErikas mentioned this issue Apr 3, 2025
Open
@stale stale bot added the wontfix This will not be worked on label Apr 26, 2025
@stale Stale
Copy link

stale bot commented Apr 27, 2025

This issue has been automatically closed because it has not had any recent activity. 😨

@stale stale bot closed this as completed Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
1 participant
@leenooks