Skip to content

Commit 662939c

Browse files
authored
chore: close gzip readers (#2134)
1 parent f53f9c1 commit 662939c

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

pkg/airgap/materialize.go

+2
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ func MaterializeAirgap(airgapReader io.Reader) error {
2424
if err != nil {
2525
return fmt.Errorf("failed to decompress airgap file: %w", err)
2626
}
27+
defer ungzip.Close()
2728

2829
// iterate through tarball
2930
tarreader := tar.NewReader(ungzip)
@@ -117,6 +118,7 @@ func writeChartFiles(reader io.Reader) error {
117118
if err != nil {
118119
return fmt.Errorf("failed to decompress airgap file: %w", err)
119120
}
121+
defer ungzip.Close()
120122

121123
// iterate through tarball
122124
tarreader := tar.NewReader(ungzip)

pkg/airgap/version.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ import (
55
"compress/gzip"
66
"fmt"
77
"io"
8-
"sigs.k8s.io/yaml"
98

109
kotsv1beta1 "github.com/replicatedhq/kotskinds/apis/kots/v1beta1"
10+
"sigs.k8s.io/yaml"
1111
)
1212

1313
// ChannelReleaseMetadata returns the appSlug, channelID, and versionLabel of the airgap bundle
@@ -19,6 +19,7 @@ func ChannelReleaseMetadata(reader io.Reader) (appSlug, channelID, versionLabel
1919
err = fmt.Errorf("failed to decompress airgap file: %w", err)
2020
return
2121
}
22+
defer ungzip.Close()
2223

2324
// iterate through tarball
2425
tarreader := tar.NewReader(ungzip)

pkg/tgzutils/tgz.go

+1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ func Decompress(tgz, dst string) error {
2121
if err != nil {
2222
return fmt.Errorf("unable to create gzip reader: %v", err)
2323
}
24+
defer gzreader.Close()
2425

2526
tarreader := tar.NewReader(gzreader)
2627
for {

0 commit comments

Comments
 (0)