refactor generate_cmijs script

Author: cometkim

Makefile

@@ -61,7 +61,7 @@ artifacts: lib
 # Builds the core playground bundle (without the relevant cmijs files for the runtime)
 playground:
 	dune build --profile browser
-	cp ./_build/default/compiler/jsoo/jsoo_playground_main.bc.js packages/playground/compiler.js
+	cp -f ./_build/default/compiler/jsoo/jsoo_playground_main.bc.js packages/playground/compiler.js
 
 # Creates all the relevant core and third party cmij files to side-load together with the playground bundle
 playground-cmijs: artifacts

packages/playground/package.json

@@ -5,7 +5,7 @@
   "scripts": {
     "clean": "rescript clean",
     "test": "node ./playground_test.cjs",
-    "build": "rescript clean && rescript build && node ./scripts/generate_cmijs.mjs && rollup -c",
+    "build": "rescript clean && rescript build && node scripts/generate_cmijs.mjs && rollup -c",
     "upload-bundle": "./scripts/upload_bundle.sh",
     "revalidate": "./scripts/website_update_playground.sh"
   },

packages/playground/scripts/common.mjs

@@ -0,0 +1,31 @@
+// @ts-check
+
+import * as child_process from "node:child_process";
+import * as fs from "node:fs";
+import * as path from "node:path";
+
+export const compilerRootDir = path.join(
+  import.meta.dirname,
+  "..",
+  "..",
+  "..",
+);
+
+// The playground-bundling root dir
+export const playgroundDir = path.join(import.meta.dirname, "..");
+
+// Final target output directory where all the cmijs will be stored
+export const playgroundPackagesDir = path.join(playgroundDir, "packages");
+
+/**
+ * @param {string} cmd
+ */
+export function exec(cmd) {
+  console.log(`>>>>>> running command: ${cmd}`);
+  child_process.execSync(cmd, {
+    cwd: playgroundDir,
+    encoding: "utf8",
+    stdio: "inherit",
+  });
+  console.log("<<<<<<");
+}

packages/playground/scripts/generate_cmijs.mjs

@@ -13,92 +13,54 @@
  * playground bundle.
  */
 
-import * as child_process from "node:child_process";
 import * as fs from "node:fs";
 import * as path from "node:path";
 
 import resConfig from "../rescript.json" with { type: "json" };
+import {
+  exec,
+  compilerRootDir,
+  playgroundPackagesDir,
+} from "./common.mjs";
 
-const RESCRIPT_COMPILER_ROOT_DIR = path.join(
-  import.meta.dirname,
-  "..",
-  "..",
-  "..",
-);
+exec("yarn rescript clean");
+exec("yarn rescript");
 
-// The playground-bundling root dir
-const PLAYGROUND_DIR = path.join(import.meta.dirname, "..");
-
-// Final target output directory where all the cmijs will be stored
-const PACKAGES_DIR = path.join(PLAYGROUND_DIR, "packages");
+// We need to build the compiler's builtin modules as a separate cmij.
+// Otherwise we can't use them for compilation within the playground.
+buildCmij(compilerRootDir, "compiler-builtins");
 
-// Making sure this directory exists, since it's not checked in to git
-fs.mkdirSync(PACKAGES_DIR, { recursive: true });
+const packages = resConfig["bs-dependencies"];
+for (const pkgName of packages) {
+  buildCmij(
+    path.join(compilerRootDir, "node_modules", pkgName),
+    pkgName,
+  );
+}
 
 /**
- * @param {string} cmd
+ * @param {string} pkgDir
+ * @param {string} pkgName
  */
-function e(cmd) {
-  console.log(`>>>>>> running command: ${cmd}`);
-  child_process.execSync(cmd, {
-    cwd: PLAYGROUND_DIR,
-    encoding: "utf8",
-    stdio: [0, 1, 2],
-  });
-  console.log("<<<<<<");
-}
-
-e("yarn rescript clean");
-e("yarn rescript");
-
-const packages = resConfig["bs-dependencies"];
-
-// We need to build the compiler's builtin modules as a separate cmij.
-// Otherwise we can't use them for compilation within the playground.
-function buildCompilerCmij() {
-  const rescriptLibOcamlFolder = path.join(
-    RESCRIPT_COMPILER_ROOT_DIR,
+function buildCmij(pkgDir, pkgName) {
+  const libOcamlFolder = path.join(
+    pkgDir,
     "lib",
     "ocaml",
   );
 
-  const outputFolder = path.join(PACKAGES_DIR, "compiler-builtins");
+  const outputFolder = path.join(playgroundPackagesDir, pkgName);
   fs.mkdirSync(outputFolder, { recursive: true });
 
   const cmijFile = path.join(outputFolder, "cmij.js");
-
-  e(
-    `find ${rescriptLibOcamlFolder} -name "*.cmi" -or -name "*.cmj" | xargs -n1 basename | xargs js_of_ocaml build-fs -o ${cmijFile} -I ${rescriptLibOcamlFolder}`,
-  );
+  const inputFiles = fs.readdirSync(libOcamlFolder).filter(isCmij).join(" ");
+  exec(`js_of_ocaml build-fs -o ${cmijFile} -I ${libOcamlFolder} ${inputFiles}`);
 }
 
-function buildThirdPartyCmijs() {
-  for (const pkg of packages) {
-    const libOcamlFolder = path.join(
-      RESCRIPT_COMPILER_ROOT_DIR,
-      "node_modules",
-      pkg,
-      "lib",
-      "ocaml",
-    );
-    const libEs6Folder = path.join(
-      RESCRIPT_COMPILER_ROOT_DIR,
-      "node_modules",
-      pkg,
-      "lib",
-      "es6",
-    );
-    const outputFolder = path.join(PACKAGES_DIR, pkg);
-    fs.mkdirSync(outputFolder, { recursive: true });
-
-    const cmijFile = path.join(outputFolder, "cmij.js");
-
-    e(`find ${libEs6Folder} -name '*.js' -exec cp {} ${outputFolder} \\;`);
-    e(
-      `find ${libOcamlFolder} -name "*.cmi" -or -name "*.cmj" | xargs -n1 basename | xargs js_of_ocaml build-fs -o ${cmijFile} -I ${libOcamlFolder}`,
-    );
-  }
+/**
+ * @param {string} basename 
+ * @return {boolean}
+ */
+function isCmij(basename) {
+  return /\.cm(i|j)$/.test(basename);
 }
-
-buildCompilerCmij();
-buildThirdPartyCmijs();