From d1c19af62adefe2c35912b0188efde2ba8267ee5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9sar=20Tonnoir?= <cesar.tonnoir@miam.tech>
Date: Tue, 15 Dec 2020 19:57:45 +0100
Subject: [PATCH] fix cache consistency bug while deleting resources

---
 src/services/cachememory.ts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/services/cachememory.ts b/src/services/cachememory.ts
index 6ee6c02f..c64e5a2b 100644
--- a/src/services/cachememory.ts
+++ b/src/services/cachememory.ts
@@ -108,12 +108,12 @@ export class CacheMemory<R extends Resource = Resource> {
             return;
         }
         Base.forEach(this.collections, (value, url) => {
-            value.data.splice(
-                value.data.findIndex(
-                    (resource_on_collection: Resource) => resource_on_collection.type === type && resource_on_collection.id === id
-                ),
-                1
+            let resourceIndex = value.data.findIndex(
+                (resource_on_collection: Resource) => resource_on_collection.type === type && resource_on_collection.id === id
             );
+            if (resourceIndex > -1) {
+                value.data.splice(resourceIndex, 1);
+            }
         });
         resource.attributes = {}; // just for confirm deletion on view