Update detekt to v1.23.1

Author: RBusarow

build-logic/core/src/main/kotlin/modulecheck/builds/domainObjectCollection.kt

@@ -16,6 +16,9 @@
 package modulecheck.builds
 
 import org.gradle.api.DomainObjectCollection
+import org.gradle.api.Named
+import org.gradle.api.NamedDomainObjectCollection
+import org.gradle.api.internal.DefaultNamedDomainObjectCollection
 
 /**
  * Returns a collection containing the objects in this collection of the
@@ -43,3 +46,25 @@ inline fun <reified S : Any> DomainObjectCollection<in S>.withType(
  */
 inline fun <reified S : Any> DomainObjectCollection<in S>.withType(): DomainObjectCollection<S> =
   withType(S::class.java)
+
+/**
+ * Executes the specified action when an element is registered in the [NamedDomainObjectCollection].
+ * This function does not cause the registered element to be initialized or configured.
+ *
+ * @param action The action to execute when an element is registered.
+ *   It takes the name of the registered element as a parameter.
+ * @receiver The receiver [NamedDomainObjectCollection] to observe for element registration.
+ * @throws IllegalArgumentException if the receiver collection
+ *   does not extend [DefaultNamedDomainObjectCollection].
+ */
+inline fun <reified T : Named> NamedDomainObjectCollection<T>.whenElementRegistered(
+  crossinline action: (name: String) -> Unit
+) {
+  require(this is DefaultNamedDomainObjectCollection<*>) {
+    "The receiver collection must extend " +
+      "${DefaultNamedDomainObjectCollection::class.qualifiedName}, " +
+      "but this type is ${this::class.java.canonicalName}."
+  }
+
+  whenElementKnown { action(it.name) }
+}

detekt/detekt-config.yml

@@ -685,8 +685,6 @@ style:
     active: true
   OptionalUnit:
     active: false
-  OptionalWhenBraces:
-    active: false
   PreferToOverPairSyntax:
     active: false
   ProtectedMemberInFinalClass:

modulecheck-api/src/main/kotlin/modulecheck/api/context/MustBeApi.kt

@@ -237,11 +237,11 @@ private suspend fun McProject.mustBeApiIn(
  * @since 0.12.0
  */
 suspend inline fun <reified T : ConfiguredDependency> T.maybeAsApi(dependentProject: McProject): T {
-  val mustBeApi = when (this as ConfiguredDependency) {
+  val mustBeApi = when (val dep: ConfiguredDependency = this@maybeAsApi) {
     is ExternalDependency -> false
     is ProjectDependency -> when {
       configurationName.isKapt() -> false
-      else -> (this as ProjectDependency).project(dependentProject.projectCache)
+      else -> dep.project(dependentProject.projectCache)
         .mustBeApiIn(
           dependentProject = dependentProject,
           sourceSetName = configurationName.toSourceSetName(),

modulecheck-model/dependency/api/src/main/kotlin/modulecheck/model/dependency/ConfiguredDependency.kt

@@ -43,20 +43,22 @@ sealed interface ConfiguredDependency : Dependency {
     inline fun <reified T : ConfiguredDependency> T.copy(
       configurationName: ConfigurationName = this.configurationName,
       isTestFixture: Boolean = this.isTestFixture
-    ): ConfiguredDependency = when (this as ConfiguredDependency) {
-      is ExternalDependency -> (this as ExternalDependency).copy(
-        configurationName = configurationName,
-        group = group,
-        moduleName = moduleName,
-        version = version,
-        isTestFixture = isTestFixture
-      )
+    ): ConfiguredDependency {
+      return when (val dep: ConfiguredDependency = this@copy) {
+        is ExternalDependency -> dep.copy(
+          configurationName = configurationName,
+          group = dep.group,
+          moduleName = dep.moduleName,
+          version = dep.version,
+          isTestFixture = isTestFixture
+        )
 
-      is ProjectDependency -> (this as ProjectDependency).copy(
-        configurationName = configurationName,
-        path = projectPath,
-        isTestFixture = isTestFixture
-      )
+        is ProjectDependency -> dep.copy(
+          configurationName = configurationName,
+          path = dep.projectPath,
+          isTestFixture = isTestFixture
+        )
+      }
     }
   }
 }

modulecheck-parsing/groovy-antlr/src/main/kotlin/modulecheck/parsing/groovy/antlr/AntlrTreePrinter.kt

@@ -24,7 +24,9 @@ internal class AntlrTreePrinter(
 ) : AbstractTreePrinter<Tree>(whitespaceChar) {
 
   override fun Tree.children(): Sequence<Tree> = sequence {
-    (0 until childCount).forEach { yield(getChild(it)) }
+    for (it in 0 until childCount) {
+      yield(getChild(it))
+    }
   }
 
   override fun Tree.text(): String = (this as ParseTree).text

modulecheck-parsing/groovy-antlr/src/main/kotlin/modulecheck/parsing/groovy/antlr/extensions.kt

@@ -107,7 +107,9 @@ fun Tree.childrenBreadthFirst(predicate: (Tree) -> Boolean): Sequence<Tree> =
 
 /** @return a sequence of the children [Tree] nodes. */
 fun Tree.children(): Sequence<Tree> = sequence {
-  (0 until childCount).forEach { yield(getChild(it)) }
+  for (it in 0 until childCount) {
+    yield(getChild(it))
+  }
 }
 
 internal inline fun <reified T> ParserRuleContext.childrenOfType(): List<T> {