Skip to content

Commit 6a375f1

Browse files
authored
Disable HW dithering on Kindle (koreader#819)
It apparently doesn't behave like on Kobo...
1 parent abc24ac commit 6a375f1

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

ffi/framebuffer_mxcfb.lua

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,7 @@ local function refresh_koa2(fb, refreshtype, waveform_mode, x, y, w, h, dither)
309309
-- NOTE: Since there's no longer a distinction between GC16_FAST & GC16, we're done!
310310
refarea[0].temp = C.TEMP_USE_AMBIENT
311311
-- Did we request HW dithering?
312+
-- FIXME: Behaves differently than on Kobo?
312313
if dither then
313314
refarea[0].dither_mode = C.EPDC_FLAG_USE_DITHERING_ORDERED
314315
if waveform_mode == C.WAVEFORM_MODE_A2 or waveform_mode == C.WAVEFORM_MODE_DU then
@@ -345,6 +346,7 @@ local function refresh_pw4(fb, refreshtype, waveform_mode, x, y, w, h, dither)
345346
-- NOTE: Since there's no longer a distinction between GC16_FAST & GC16, we're done!
346347
refarea[0].temp = C.TEMP_USE_AMBIENT
347348
-- Did we request HW dithering?
349+
-- FIXME: Behaves differently than on Kobo?
348350
if dither then
349351
refarea[0].dither_mode = C.EPDC_FLAG_USE_DITHERING_ORDERED
350352
if waveform_mode == C.WAVEFORM_MODE_A2 or waveform_mode == C.WAVEFORM_MODE_DU then
@@ -534,7 +536,9 @@ function framebuffer:init()
534536

535537
-- NOTE: The PW4 essentially uses the same driver as the KOA2, it's just passing a slightly smaller mxcfb_update_data struct
536538
if isKOA2 or isPW4 then
537-
self.device.canHWDither = yes
539+
-- FIXME: Someone with the device will have to check if/how HW dithering is supposed to be requested,
540+
-- as the Kobo Mk.7 way doesn't appear to work, at the very least on the PW4 (c.f., #4602)
541+
--self.device.canHWDither = yes
538542
if isKOA2 then
539543
self.mech_refresh = refresh_koa2
540544
else

0 commit comments

Comments
 (0)