@@ -309,6 +309,7 @@ local function refresh_koa2(fb, refreshtype, waveform_mode, x, y, w, h, dither)
309
309
-- NOTE: Since there's no longer a distinction between GC16_FAST & GC16, we're done!
310
310
refarea [0 ].temp = C .TEMP_USE_AMBIENT
311
311
-- Did we request HW dithering?
312
+ -- FIXME: Behaves differently than on Kobo?
312
313
if dither then
313
314
refarea [0 ].dither_mode = C .EPDC_FLAG_USE_DITHERING_ORDERED
314
315
if waveform_mode == C .WAVEFORM_MODE_A2 or waveform_mode == C .WAVEFORM_MODE_DU then
@@ -345,6 +346,7 @@ local function refresh_pw4(fb, refreshtype, waveform_mode, x, y, w, h, dither)
345
346
-- NOTE: Since there's no longer a distinction between GC16_FAST & GC16, we're done!
346
347
refarea [0 ].temp = C .TEMP_USE_AMBIENT
347
348
-- Did we request HW dithering?
349
+ -- FIXME: Behaves differently than on Kobo?
348
350
if dither then
349
351
refarea [0 ].dither_mode = C .EPDC_FLAG_USE_DITHERING_ORDERED
350
352
if waveform_mode == C .WAVEFORM_MODE_A2 or waveform_mode == C .WAVEFORM_MODE_DU then
@@ -534,7 +536,9 @@ function framebuffer:init()
534
536
535
537
-- NOTE: The PW4 essentially uses the same driver as the KOA2, it's just passing a slightly smaller mxcfb_update_data struct
536
538
if isKOA2 or isPW4 then
537
- self .device .canHWDither = yes
539
+ -- FIXME: Someone with the device will have to check if/how HW dithering is supposed to be requested,
540
+ -- as the Kobo Mk.7 way doesn't appear to work, at the very least on the PW4 (c.f., #4602)
541
+ -- self.device.canHWDither = yes
538
542
if isKOA2 then
539
543
self .mech_refresh = refresh_koa2
540
544
else
0 commit comments