-
Notifications
You must be signed in to change notification settings - Fork 344
Add BEST EFFORT
controller switch tests for Controller Manager
#521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Please assign to me. |
Originally posted by @destogl in #582 (comment) |
@christophfroehlich Can I take up this issue? I am not very familiar with building tests, but I would like to take this opportunity to learn and contribute to the community. |
Very welcome! Writing tests is mostly understanding the intention of the code itself, and copy-pasting other tests ;) |
Hello! In the above file, there are some tests already present. Better take a look at some coverage builds and understand what else needs to be implemented. I already see some tests with BEST_EFFORT. |
I'll check them out and come back to you if I am stuck somewhere. |
Hey @saikishor @christophfroehlich, sorry for the long delay. I have some questions about the second test for "activating multiple controllers when one has a resource collision". I was thinking of creating a parametric test for both strictness values. I started three controllers, out of which one and two are in resource collision. As expected, in the |
Uh oh!
There was an error while loading. Please reload this page.
We could probably use parameterized tests for this to save some code.
Originally posted by @destogl in #461 (comment)
Description:
controller_manager/test/test_controller_manager.cpp
BEST_EFFORT
- this means that the test will have to be duplicated (we can optimize/reduce code in the second step)STRICT
controller switch is hereBEST_EFFORT
means the following: if we have a situation where multiple controllers "are switched" and can not be switched the all other that can will be still switchedcontroller_manager/doc/userdoc.rst
The text was updated successfully, but these errors were encountered: