Skip to content

Commit 99dab88

Browse files
committed
remove second generic parameter for create_service method
1 parent 13fcc0d commit 99dab88

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

examples/minimal_client_service/src/minimal_service.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ fn main() -> Result<(), Error> {
1818
let node = rclrs::create_node(&context, "minimal_service")?;
1919

2020
let _server = node
21-
.create_service::<example_interfaces::srv::AddTwoInts, _>("add_two_ints", handle_service)?;
21+
.create_service::<example_interfaces::srv::AddTwoInts>("add_two_ints", handle_service)?;
2222

2323
println!("Starting server");
2424
rclrs::spin(node).map_err(|err| err.into())

rclrs/src/node.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -263,14 +263,13 @@ impl Node {
263263
///
264264
/// [1]: crate::Service
265265
// TODO: make service's lifetime depend on node's lifetime
266-
pub fn create_service<T, F>(
266+
pub fn create_service<T>(
267267
&self,
268268
topic: &str,
269-
callback: F,
269+
callback: impl FnMut(&rmw_request_id_t, T::Request) -> T::Response + 'static + Send,
270270
) -> Result<Arc<Service<T>>, RclrsError>
271271
where
272272
T: rosidl_runtime_rs::Service,
273-
F: FnMut(&rmw_request_id_t, T::Request) -> T::Response + 'static + Send,
274273
{
275274
let service = Arc::new(Service::<T>::new(
276275
Arc::clone(&self.rcl_node_mtx),

0 commit comments

Comments
 (0)