Skip to content

Commit 9953abe

Browse files
authored
Merge pull request #2433 from wojtha/fix-rails-71-reconnect
Add optional argument to reconnect for Rails 7.1+ compatibility
2 parents 3be5045 + fc4c4f3 commit 9953abe

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

lib/active_record/connection_adapters/oracle_enhanced_adapter.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,7 @@ def reconnect
452452
end
453453

454454
# Reconnects to the database.
455-
def reconnect! # :nodoc:
455+
def reconnect!(restore_transactions: false) # :nodoc:
456456
super
457457
_connection.reset!
458458
rescue OracleEnhanced::ConnectionException => e

spec/active_record/connection_adapters/oracle_enhanced/connection_spec.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,12 @@
3030
expect(ActiveRecord::Base.connection).to be_active
3131
end
3232

33+
it "should be active after reconnection to database with restore_transactions: true" do
34+
ActiveRecord::Base.establish_connection(CONNECTION_PARAMS)
35+
ActiveRecord::Base.connection.reconnect!(restore_transactions: true)
36+
expect(ActiveRecord::Base.connection).to be_active
37+
end
38+
3339
it "should use database default cursor_sharing parameter value force by default" do
3440
# Use `SYSTEM_CONNECTION_PARAMS` to query v$parameter
3541
ActiveRecord::Base.establish_connection(SYSTEM_CONNECTION_PARAMS)

0 commit comments

Comments
 (0)