maint: drop python 3.8 support (#321)

* drop python 3.8 support

* update from precommit

Author: isabelizimm

.github/workflows/ci.yml

@@ -20,13 +20,13 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
+        python: ["3.9", "3.10", "3.11", "3.12", "3.13"]
         os: ["ubuntu-latest"]
         pytest_opts: ["--workers 4 --tests-per-worker 1"]
         requirements: [""]
         include:
           - os: "ubuntu-latest"
-            python: "3.8"
+            python: "3.9"
             requirements: "requirements/minimum.txt"
           - os: "macos-latest"
             python: "3.10"

.github/workflows/code-checks.yml

@@ -24,12 +24,12 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-python@v4
         with:
-          python-version: 3.12 # Use the maximum version supported by python-pins
+          python-version: 3.13 # Use the maximum version supported by python-pins
       - name: Install dependencies
         shell: bash
         run: |
           python -m pip install --upgrade pip
           python -m pip install -e .[check]
       - uses: jakebailey/pyright-action@v2
         with:
-          version: 1.1.372 # Manually sync with setup.cfg
+          version: 1.1.372

Makefile

@@ -38,10 +38,10 @@ docs-build:
 docs-clean:
 	rm -rf docs/_build docs/api/api_card
 
-requirements/dev.txt: setup.cfg
+requirements/dev.txt: pyproject.toml
 	@# allows you to do this...
 	@# make requirements | tee > requirements/some_file.txt
-	@pip-compile setup.cfg --rebuild --extra doc --extra test --extra check --output-file=- > $@
+	@pip-compile pyproject.toml --rebuild --extra doc --extra test --extra check --output-file=- > $@
 
 binder/requirements.txt: requirements/dev.txt
 	cp $< $@

pins/boards.py

@@ -6,10 +6,11 @@
 import re
 import shutil
 import tempfile
+from collections.abc import Mapping, Sequence
 from datetime import datetime, timedelta
 from io import IOBase
 from pathlib import Path
-from typing import Mapping, Protocol, Sequence
+from typing import Protocol
 
 from importlib_resources import files
 from importlib_resources.abc import Traversable

pins/cache.py

@@ -5,8 +5,8 @@
 import shutil
 import time
 import urllib.parse
+from collections.abc import Iterator
 from pathlib import Path
-from typing import Iterator
 
 import humanize
 from fsspec import register_implementation

pins/drivers.py

@@ -1,5 +1,5 @@
+from collections.abc import Sequence
 from pathlib import Path
-from typing import Sequence
 
 from .config import PINS_ENV_INSECURE_READ, get_allow_pickle_read
 from .errors import PinsInsecureReadError

pins/meta.py

@@ -1,8 +1,9 @@
 from __future__ import annotations
 
+from collections.abc import Mapping, Sequence
 from dataclasses import InitVar, asdict, dataclass, field, fields
 from pathlib import Path
-from typing import Any, ClassVar, Mapping, Sequence
+from typing import Any, ClassVar
 
 import yaml
 

pins/rsconnect/api.py

@@ -3,12 +3,12 @@
 import logging
 import os
 import tempfile
-from collections.abc import Mapping
+from collections.abc import Mapping, Sequence
 from dataclasses import dataclass
 from functools import partial
 from io import IOBase
 from pathlib import Path
-from typing import Generic, Literal, Sequence, TypeVar, overload
+from typing import Generic, Literal, TypeVar, overload
 from urllib.parse import urlencode
 
 import requests

pins/rsconnect/fs.py

@@ -1,8 +1,9 @@
 from __future__ import annotations
 
+from collections.abc import Sequence
 from dataclasses import asdict, dataclass, field, fields
 from pathlib import Path
-from typing import ClassVar, Sequence
+from typing import ClassVar
 
 from fsspec import AbstractFileSystem
 

pins/tests/test_rsconnect_api.py

@@ -228,7 +228,10 @@ def test_rsconnect_api_get_content_bundle_archive(rsc_short):
     bundle = create_content_bundle(rsc_short, content["guid"])
 
     # create temporary directories for content source and dest to download to ----
-    with tempfile.TemporaryDirectory() as tmp_src, tempfile.TemporaryDirectory() as tmp_dst:
+    with (
+        tempfile.TemporaryDirectory() as tmp_src,
+        tempfile.TemporaryDirectory() as tmp_dst,
+    ):
         create_content_bundle(rsc_short, content["guid"], tmp_src)
 
         # download .tar.gz archive to a temporary file and unzip ----

pins/versions.py

@@ -1,10 +1,10 @@
 from __future__ import annotations
 
 import logging
+from collections.abc import Mapping, Sequence
 from dataclasses import asdict, dataclass
 from datetime import datetime
 from pathlib import Path
-from typing import Mapping, Sequence
 
 from xxhash import xxh64
 

pyproject.toml

@@ -10,15 +10,14 @@ maintainers = [{ name = "Isabel Zimmerman", email = "[email protected]"
 keywords = ["data", "tidyverse"]
 classifiers = [
     "Programming Language :: Python :: 3 :: Only",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
     "Programming Language :: Python :: 3.12",
     "Programming Language :: Python :: 3.13",
     "License :: OSI Approved :: MIT License",
 ]
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 dynamic = ["version"]
 dependencies = [
     "appdirs<2",                # Using appdirs rather than platformdirs is deliberate, see https://github.com/rstudio/pins-python/pull/239