Merge pull request #1342 from Shopify/vs-enable-method-def-parenthesis

Enable `Style/MethodDefParentheses` rule

Author: vinistock

.rubocop.yml

@@ -2,6 +2,14 @@ AllCops:
   TargetRubyVersion: 3.0
   DisabledByDefault: true
   SuggestExtensions: false
+  Exclude:
+    # Exclude files that are auto generated
+    - "lib/rdoc/rd/block_parser.rb"
+    - "lib/rdoc/rd/inline_parser.rb"
+    - "lib/rdoc/markdown.rb"
+    - "lib/rdoc/markdown/literals.rb"
+    # Exclude dependency files when installing them under vendor
+    - "vendor/**/*"
 
 Layout/TrailingWhitespace:
   Enabled: true
@@ -20,3 +28,6 @@ Layout/SpaceAfterComma:
 
 Lint/UnreachableCode:
   Enabled: true
+
+Style/MethodDefParentheses:
+  Enabled: true

lib/rdoc/code_object.rb

@@ -236,7 +236,7 @@ def force_documentation=(value)
   #
   # Set to +nil+ to clear RDoc's cached value
 
-  def full_name= full_name
+  def full_name=(full_name)
     @full_name = full_name
   end
 
@@ -316,7 +316,7 @@ def parent_name
   ##
   # Records the RDoc::TopLevel (file) where this code object was defined
 
-  def record_location top_level
+  def record_location(top_level)
     @ignored    = false
     @suppressed = false
     @file       = top_level
@@ -358,7 +358,7 @@ def stop_doc
   ##
   # Sets the +store+ that contains this CodeObject
 
-  def store= store
+  def store=(store)
     @store = store
 
     return unless @track_visibility