-
Notifications
You must be signed in to change notification settings - Fork 49
Add Facebook share button #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I never actually asked: @Brennaleker, do you want to be assigned to this? |
I've gone ahead and unassigned this for visibility. For the current implementation their is an existing issue with SocialShareButton. Another option would be to use a different dependency or custom JS for Facebook only. |
hey, is this issue solved as I have checked the website and facebook share button has worked there for me |
@Gauravano Yep, this is still open! The website you're looking at is the playtime homepage, not this app. We don't have a production version of this up yet, but the staging version can be found here. The share buttons appear on the wishlists. This task is to add the facebook button and make it work. That probably will require whitelisting the staging url somewhere; the socialsharebutton gem probably has some documentation on how to do that. Alternatively, if the issue's with the gem itself, it may be worth getting rid of the dependency and adding the share buttons manually. Are you interested in taking this issue on? |
Yes, I want to try |
Awesome! 🎉 Let us know if you have any questions. |
Continuation of #107
The Facebook social share button wasn't working, so we decided to remove it for the first release. Now that development is a little more leisurely, we should add it back and get it working.
The text was updated successfully, but these errors were encountered: