Skip to content

Add Facebook share button #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leesharma opened this issue Oct 2, 2017 · 6 comments
Open

Add Facebook share button #112

leesharma opened this issue Oct 2, 2017 · 6 comments

Comments

@leesharma
Copy link
Collaborator

Continuation of #107

The Facebook social share button wasn't working, so we decided to remove it for the first release. Now that development is a little more leisurely, we should add it back and get it working.

@leesharma
Copy link
Collaborator Author

I never actually asked: @Brennaleker, do you want to be assigned to this?

@Brennaleker Brennaleker removed their assignment Oct 15, 2017
@Brennaleker
Copy link
Contributor

I've gone ahead and unassigned this for visibility. For the current implementation their is an existing issue with SocialShareButton. Another option would be to use a different dependency or custom JS for Facebook only.

@grvsachdeva
Copy link

grvsachdeva commented Oct 16, 2017

hey, is this issue solved as I have checked the website and facebook share button has worked there for me

@leesharma
Copy link
Collaborator Author

@Gauravano Yep, this is still open! The website you're looking at is the playtime homepage, not this app. We don't have a production version of this up yet, but the staging version can be found here.

The share buttons appear on the wishlists. This task is to add the facebook button and make it work. That probably will require whitelisting the staging url somewhere; the socialsharebutton gem probably has some documentation on how to do that.

Alternatively, if the issue's with the gem itself, it may be worth getting rid of the dependency and adding the share buttons manually.

Are you interested in taking this issue on?

@grvsachdeva
Copy link

Yes, I want to try
I will first use social-share-button gem if this doesn't work then I'll try another method.

@leesharma
Copy link
Collaborator Author

Awesome! 🎉 Let us know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants