Atom feed cleanup

* Wrap tweets in presenter, clean up view
* Add sanity check view specs
* Add DatabaseCleaner

[#1]

Author: justincampbell

app/models/tweet.rb

@@ -4,6 +4,6 @@ class Tweet < ActiveRecord::Base
   mount_uploader :image, ImageUploader
 
   def self.published
-    where(published: true)
+    where(published: true).where("published_at is not null")
   end
 end

app/presenters/tweet/feed_presenter.rb

@@ -0,0 +1,41 @@
+class Tweet::FeedPresenter
+  attr_accessor :tweet
+
+  def initialize(tweet)
+    self.tweet = tweet
+  end
+
+  def self.model_name
+    Tweet.model_name
+  end
+
+  def author
+    username
+  end
+
+  def content
+    <<-HTML.gsub /^ {6}/, ''
+      #{tweet_text}
+      <br />
+      <img src="#{media_url}" />
+    HTML
+  end
+
+  def title
+    "#{username}: #{tweet_text}".truncate 50
+  end
+
+  def url
+    media_display_url
+  end
+
+  def username
+    "@#{tweet.username}"
+  end
+
+  private
+
+  def method_missing(*args)
+    tweet.send *args
+  end
+end

app/views/tweets/index.atom.builder

@@ -1,16 +1,18 @@
+@tweets.map! { |tweet| Tweet::FeedPresenter.new tweet }
+
 atom_feed root_url: tweets_url do |feed|
   feed.title "#RubyFriends"
   feed.updated @tweets.first.updated_at
 
   @tweets.each do |tweet|
-    feed.entry tweet, url: tweet.media_display_url, id: tweet.tweet_id do |entry|
-      entry.url tweet.media_display_url
-      entry.title "@#{tweet.username}: #{tweet.tweet_text.truncate 50}"
-      entry.content tweet.tweet_text, type: :html
+    feed.entry tweet do |entry|
+      entry.url tweet.url
+      entry.title tweet.title
+      entry.content tweet.content, type: :html
       entry.updated tweet.updated_at.iso8601
 
       entry.author do |author|
-        author.name "@#{tweet.username}"
+        author.name tweet.author
       end
     end
   end

spec/presenters/tweet/feed_presenter_spec.rb

@@ -0,0 +1,44 @@
+require 'spec_helper'
+
+describe Tweet::FeedPresenter do
+  subject { feed_presenter }
+
+  let(:feed_presenter) { described_class.new tweet }
+  let(:tweet) {
+    Tweet.new tweet_id: "263515718753079296",
+      tweet_text: "at @SteelCityRuby with @coreyhaines - one of my favorite #rubyfriends http://t.co/cyL9StoS",
+      username: "joshsusser",
+      media_url: "http://p.twimg.com/A6gyJmlCUAA9Il2.jpg",
+      image: "A6gyJmlCUAA9Il2.jpg",
+      media_display_url: "pic.twitter.com/cyL9StoS"
+  }
+
+  its(:author) { should == "@joshsusser" }
+  its(:url) { should == tweet.media_display_url }
+  its(:username) { should == "@joshsusser" }
+
+  describe "#content" do
+    subject(:content) { feed_presenter.content }
+
+    it "contains the tweet's text" do
+      should match /#{tweet.tweet_text}/
+    end
+
+    it "contains an image tag with the image" do
+      should match /<img /
+      should match /src="#{tweet.media_url}"/
+    end
+  end
+
+  describe "#title" do
+    subject(:title) { feed_presenter.title }
+
+    it "begins with the username" do
+      title.starts_with?("@joshsusser: at @SteelCityRuby with").should be_true
+    end
+
+    it "truncates to 50 characters" do
+      should have(50).characters
+    end
+  end
+end

spec/requests/tweets_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe "tweets" do
+  before :each do
+    Tweet.create! tweet_text: "Hi!", published: true, published_at: Time.now
+  end
+
+  it "responds to html" do
+    visit tweets_path
+
+    page.should have_content("Hi!")
+  end
+
+  it "responds to atom" do
+    visit tweets_path
+
+    page.should have_content("Hi!")
+  end
+end

spec/spec_helper.rb

@@ -16,4 +16,16 @@
   config.infer_base_class_for_anonymous_controllers = true
   config.order = :random
   config.treat_symbols_as_metadata_keys_with_true_values = true
+
+  config.before :suite do
+    DatabaseCleaner.strategy = :truncation
+  end
+
+  config.before :each do
+    DatabaseCleaner.start
+  end
+
+  config.after :each do
+    DatabaseCleaner.clean
+  end
 end