Skip to content

Commit c6d89cd

Browse files
committed
Pin dependencies when using MSRV
A recent release of `form_urlencoded` breaks our dev build when using 1.41.1 toolchain. Pin the `url` and `form_urlencoded` dependencies when on 1.41.1 toolchain.
1 parent 15b57cd commit c6d89cd

File tree

2 files changed

+20
-0
lines changed

2 files changed

+20
-0
lines changed

README.md

+8
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,14 @@ or in [the `examples/` directory](https://github.com/apoelstra/rust-miniscript/t
3838
This library should always compile with any combination of features (minus
3939
`no-std`) on **Rust 1.41.1** or **Rust 1.47** with `no-std`.
4040

41+
Some dependencies do not play nicely with our MSRV, if you are running the tests
42+
you may need to pin as follows:
43+
44+
```
45+
cargo update --package url --precise 2.2.2
46+
cargo update --package form_urlencoded --precise 1.0.1
47+
```
48+
4149
## Contributing
4250
Contributions are generally welcome. If you intend to make larger changes please
4351
discuss them in an issue before PRing them to avoid duplicate work and

contrib/test.sh

+12
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,18 @@ cargo update -p serde_derive --precise 1.0.142
1010
cargo --version
1111
rustc --version
1212

13+
# Work out if we are using a nightly toolchain.
14+
MSRV=false
15+
if cargo --version | grep "1\.41\.0"; then
16+
MSRV=true
17+
fi
18+
19+
# form_urlencoded 1.1.0 breaks MSRV.
20+
if [ "$MSRV" = true ]; then
21+
cargo update -p url --precise 2.2.2
22+
cargo update -p form_urlencoded --precise 1.0.1
23+
fi
24+
1325
# Format if told to
1426
if [ "$DO_FMT" = true ]
1527
then

0 commit comments

Comments
 (0)