Skip to content

Commit 59e796a

Browse files
committed
Minutes for this weeks meeting
1 parent 1bd7528 commit 59e796a

File tree

2 files changed

+79
-1
lines changed

2 files changed

+79
-1
lines changed

minutes/meeting notes 2017-08-14.md

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
# August 14th 2017
2+
3+
Agenda week, rustdoc rewrite
4+
5+
## Triage
6+
7+
We accepted https://github.com/rust-lang/rust/pull/43782 for uplift to beta.
8+
9+
10+
## Background
11+
12+
* repo: https://github.com/steveklabnik/rustdoc
13+
14+
## Notes
15+
16+
Steve gave a brief status update and I failed to take notes, sorry.
17+
18+
### Triaging current Rustdoc capabilities
19+
20+
What can we break?
21+
22+
* can we remove rustdoc plugins?
23+
- all: what even are these?
24+
- https://github.com/rust-lang/rust/blob/master/src/librustdoc/plugins.rs
25+
- load dynamic libs at runtime
26+
- pluggable rustdoc passes
27+
- unstable - compiler internals (rustdoc internals)
28+
- ACTION: let's do a Cargo bomb run, then remove
29+
30+
* command line flags
31+
- in general - warning cycle and remove them
32+
- passes - can effectively be replaced by an explicit 'document private items' flag
33+
- add CSS file - alternative - template directory
34+
* motivtion is to change the colours of docs
35+
* deprecation warning, but don't remove from current
36+
- playground URL flag - if you don't give it, don't get run buttons
37+
* default to rust-lang playground?
38+
* problem if you're not one of the top 100 crates
39+
* wait and see on this one (do we need to warn about anything? Steve to talk
40+
to infra team about playground future)
41+
* there's also a directive to use in the source
42+
43+
- do not generate Table of Contents
44+
* only applies when run on a markdown file, not Rust source
45+
* used in reference
46+
* do people use the markdown documenting feature at all?
47+
- Gankro? For his blog. Others like this?
48+
- docs.rust-lang.org
49+
- used to test code in markdown
50+
- some crates (e.g., nom) splice markdown *into* docs
51+
- `--input-format`
52+
* basically ignored atm
53+
54+
### Feature request: show which functions can (transitively) panic
55+
56+
Unclear if we can even implement this. Also controversial as to whether this
57+
would actually be useful.
58+
59+
### Theming
60+
61+
Current plan of record is to support CSS themes in a directory that the client
62+
searches, and presents a menu for the user to pick a theme.
63+
64+
* mdbook does this - https://doc.rust-lang.org/book/second-edition/
65+
* good for minor changes
66+
* we provide some themes (e.g., dark theme, high contrast/accessible); users can
67+
extend with their own themes
68+
* if we pull in mdbook, theming should be unified (and also with rustw)
69+
70+
For more serious presentation changes, write your own frontend.
71+
72+
### Markdown
73+
74+
Currently in the new rustdoc, markdown is rendered in the client. CommonMark
75+
spec compliant, should be compatible with Pulldown, therefore, no repeat of the
76+
current warning cycle issues.

twidt/drafts/issue-2.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ questions, come chat to us in #[rust-dev-tools](irc://moznet/rust-dev-tools).
1414

1515
* TODO news
1616

17+
TODO contribution opportunities
18+
1719

1820
## Releases
1921

@@ -34,7 +36,7 @@ questions, come chat to us in #[rust-dev-tools](irc://moznet/rust-dev-tools).
3436

3537
## Meetings
3638

39+
* Rustdoc rewrite [2017-08-14](https://github.com/nrc/dev-tools-team/blob/master/minutes/meeting notes 2017-08-14.md)
3740
* TODO
38-
* Rustdoc rewrite [2017-08-14](https://github.com/nrc/dev-tools-team/blob/master/minutes/TODO.md)
3941
* Topic [date](https://github.com/nrc/dev-tools-team/blob/master/minutes/TODO.md)
4042

0 commit comments

Comments
 (0)