Skip to content

Add ADC support #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liamdiprose opened this issue Aug 1, 2018 · 4 comments
Open

Add ADC support #11

liamdiprose opened this issue Aug 1, 2018 · 4 comments

Comments

@liamdiprose
Copy link

Opening this issue to discuss the addition of ADC support.

Just as stated in my other issue #10 , I have an upcoming project that aims to process audio using Rust. For this project, I will need ADC support for audio input.

I am happy to add support for the ADC's, but unlike the PWM support, I do not know how much work is required.

Are there any points we need to discuss concerning the addition of ADC support?

@thejpster
Copy link
Member

As with PWM, if there's a HAL, we should use it. If there isn't a HAL, we should propose one (keeping it in this tree for now, until it is accepted/merged up-stream).

I haven't had need for an ADC so I'm open to suggestions on the API.

@thejpster
Copy link
Member

So, nrf52-hal has an API for their saadc peripheral. We could crib that?

@liamdiprose
Copy link
Author

Hey, thanks for pinging me on this. I've just started getting back into Rust / Embedded.

Just so we're clear, by API you're talking about the Saadc::new function and SaadcExt trait?

@vipierozan99
Copy link

Hey, I`ve done some tinkering with the adc module, it´s very early tho. Suggestions and directions are welcome, there is a pull request #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants