Skip to content

Commit 962efd7

Browse files
bors[bot]eldruin
andauthored
Merge #376
376: Remove ADC traits r=therealprof a=eldruin The traits are quite complicated to use in generic code. It seems users would be better served by inherent methods. Also, these traits are `nb`-only. I would propose to remove these traits before 1.0.0 and readd/redesign them later if needed. TODO if merged: - Add tracking issue like for the other removed traits. Co-authored-by: Diego Barrios Romero <[email protected]>
2 parents 47df22c + 0b64ff5 commit 962efd7

File tree

3 files changed

+3
-115
lines changed

3 files changed

+3
-115
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
1313
- `spi`: Add `SpiDevice` trait to represent a single device in a (possibly shared) bus, with managed chip-select (CS) pin.
1414
- `spi`: Clarify that implementations are allowed to return before operations are finished, add `flush` to wait until finished.
1515

16+
### Removed
17+
- ADC traits: `adc::nb::OneShot` and `adc::nb::Channel`.
18+
1619
## [v1.0.0-alpha.7] - 2022-02-09
1720

1821
*** This is (also) an alpha release with breaking changes (sorry) ***

src/adc.rs

Lines changed: 0 additions & 114 deletions
This file was deleted.

src/lib.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,6 @@
355355

356356
pub mod fmt;
357357
pub use nb;
358-
pub mod adc;
359358
pub mod can;
360359
pub mod delay;
361360
pub mod digital;

0 commit comments

Comments
 (0)