Skip to content

Commit 5a9e9b0

Browse files
committed
Auto merge of rust-lang#12628 - franciscoBSalgueiro:fix-book-links, r=flip1995
Add missing links in the book Added a few missing links marked with FIXME in the development book. changelog: none
2 parents 398a52a + b6486fa commit 5a9e9b0

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

book/src/development/defining_lints.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,8 @@ $ cargo dev new_lint --name=lint_name --pass=late --category=pedantic
6262
There are two things to note here:
6363

6464
1. `--pass`: We set `--pass=late` in this command to do a late lint pass. The
65-
alternative is an `early` lint pass. We will discuss this difference in a
66-
later chapter.
67-
<!-- FIXME: Link that "later chapter" when lint_passes.md is merged -->
65+
alternative is an `early` lint pass. We will discuss this difference in the
66+
[Lint Passes] chapter.
6867
2. `--category`: If not provided, the `category` of this new lint will default
6968
to `nursery`.
7069

@@ -194,12 +193,12 @@ store.register_late_pass(|_| Box::new(foo_functions::FooFunctions));
194193

195194
As you might have guessed, where there's something late, there is something
196195
early: in Clippy there is a `register_early_pass` method as well. More on early
197-
vs. late passes in a later chapter.
198-
<!-- FIXME: Link that "later chapter" when lint_passes.md is merged -->
196+
vs. late passes in the [Lint Passes] chapter.
199197

200198
Without a call to one of `register_early_pass` or `register_late_pass`, the lint
201199
pass in question will not be run.
202200

203201

204202
[all_lints]: https://rust-lang.github.io/rust-clippy/master/
205203
[lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
204+
[Lint Passes]: lint_passes.md

book/src/development/lint_passes.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ questions already, but the parser is okay with it. This is what we
5050
mean when we say `EarlyLintPass` deals with only syntax on the AST level.
5151

5252
Alternatively, think of the `foo_functions` lint we mentioned in
53-
define new lints <!-- FIXME: add link --> chapter.
53+
the [Define New Lints](defining_lints.md) chapter.
5454

5555
We want the `foo_functions` lint to detect functions with `foo` as their name.
5656
Writing a lint that only checks for the name of a function means that we only

0 commit comments

Comments
 (0)