Auto merge of rust-lang#120593 - maurer:android-bump, r=Mark-Simulacrum,workingjubilee

Update Android in CI

We are currently using a 10+ year old Android image, and it has caused trouble when working on rust-lang#120326.

Our current NDK (25) only supports API 19+, so we were already out of spec. This PR:

1. Bumps the API used by the emulator in CI to 21, as per [NDK-26's release notes](https://github.com/android/ndk/wiki/Changelog-r26) deprecating 19 and 20 as targets.
2. Activates aarch64 testing on the emulator, since the base image is now a 64-bit image.
3. Bumps the NDK to 26b

Author: bors

.github/workflows/ci.yml

@@ -204,7 +204,7 @@ jobs:
               - self-hosted
               - ARM64
               - linux
-          - name: arm-android
+          - name: aarch64-android
             os: ubuntu-20.04-8core-32gb
             env: {}
           - name: armhf-gnu

config.example.toml

@@ -392,7 +392,7 @@
 #metrics = false
 
 # Specify the location of the Android NDK. Used when targeting Android.
-#android-ndk = "/path/to/android-ndk-r25b"
+#android-ndk = "/path/to/android-ndk-r26b"
 
 # =============================================================================
 # General install configuration options

src/bootstrap/src/utils/cc_detect.rs

@@ -239,18 +239,16 @@ pub(crate) fn ndk_compiler(compiler: Language, triple: &str, ndk: &Path) -> Path
         triple.to_string()
     };
 
-    // API 19 is the earliest API level supported by NDK r25b but AArch64 and x86_64 support
-    // begins at API level 21.
-    let api_level =
-        if triple.contains("aarch64") || triple.contains("x86_64") { "21" } else { "19" };
+    // The earliest API supported by NDK r26b is 21.
+    let api_level = "21";
     let compiler = format!("{}{}-{}", triple_translated, api_level, compiler.clang());
     let host_tag = if cfg!(target_os = "macos") {
         // The NDK uses universal binaries, so this is correct even on ARM.
         "darwin-x86_64"
     } else if cfg!(target_os = "windows") {
         "windows-x86_64"
     } else {
-        // NDK r25b only has official releases for macOS, Windows and Linux.
+        // NDK r26b only has official releases for macOS, Windows and Linux.
         // Try the Linux directory everywhere else, on the assumption that the OS has an
         // emulation layer that can cope (e.g. BSDs).
         "linux-x86_64"

src/bootstrap/src/utils/change_tracker.rs

@@ -170,4 +170,9 @@ pub const CONFIG_CHANGE_HISTORY: &[ChangeInfo] = &[
         severity: ChangeSeverity::Warning,
         summary: "`rust.split-debuginfo` has been moved to `target.<triple>.split-debuginfo` and its default value is determined for each target individually.",
     },
+    ChangeInfo {
+        change_id: 120593,
+        severity: ChangeSeverity::Info,
+        summary: "Removed android-ndk r25b support in favor of android-ndk r26b.",
+    },
 ];

src/ci/docker/host-x86_64/arm-android/Dockerfile renamed to src/ci/docker/host-x86_64/aarch64-android/Dockerfile

@@ -6,7 +6,7 @@ RUN sh /scripts/android-base-apt-get.sh
 
 COPY scripts/android-ndk.sh /scripts/
 RUN . /scripts/android-ndk.sh && \
-    download_ndk android-ndk-r25b-linux.zip
+    download_ndk android-ndk-r26b-linux.zip
 
 RUN dpkg --add-architecture i386 && \
     apt-get update && \
@@ -21,14 +21,14 @@ RUN dpkg --add-architecture i386 && \
 
 COPY scripts/android-sdk.sh /scripts/
 COPY scripts/android-sdk-manager.py /scripts/
-COPY host-x86_64/arm-android/android-sdk.lock /android/sdk/android-sdk.lock
+COPY host-x86_64/aarch64-android/android-sdk.lock /android/sdk/android-sdk.lock
 RUN /scripts/android-sdk.sh
 
 ENV PATH=$PATH:/android/sdk/emulator
 ENV PATH=$PATH:/android/sdk/tools
 ENV PATH=$PATH:/android/sdk/platform-tools
 
-ENV TARGETS=arm-linux-androideabi
+ENV TARGETS=arm-linux-androideabi,aarch64-linux-android
 
 ENV RUST_CONFIGURE_ARGS --android-ndk=/android/ndk/
 

src/ci/docker/host-x86_64/aarch64-android/android-sdk.lock

@@ -0,0 +1,6 @@
+emulator emulator-linux_x64-11237101.zip 0fd36dd5a7be6ee8770776a95c2933541d9243f3
+patcher;v4 3534162-studio.sdk-patcher.zip 046699c5e2716ae11d77e0bad814f7f33fab261e
+platform-tools platform-tools_r34.0.5-linux.zip 96097475cf7b279fdd8f218f5d043ffe94104ec3
+platforms;android-21 android-21_r02.zip 53536556059bb29ae82f414fd2e14bc335a4eb4c
+system-images;android-21;default;arm64-v8a sys-img/android/arm64-v8a-21_r04.zip c4375f1b4b4cd21a8617660e25f621cedcbd8332
+tools sdk-tools-linux-4333796.zip 8c7c28554a32318461802c1291d76fccfafde054

src/ci/docker/host-x86_64/arm-android/android-sdk.lock

@@ -6,7 +6,7 @@ RUN sh /scripts/android-base-apt-get.sh
 # ndk
 COPY scripts/android-ndk.sh /scripts/
 RUN . /scripts/android-ndk.sh && \
-    download_ndk android-ndk-r25b-linux.zip
+    download_ndk android-ndk-r26b-linux.zip
 
 # env
 ENV TARGETS=arm-linux-androideabi

src/ci/docker/host-x86_64/dist-android/Dockerfile

@@ -381,7 +381,7 @@ jobs:
           - name: aarch64-gnu
             <<: *job-aarch64-linux
 
-          - name: arm-android
+          - name: aarch64-android
             <<: *job-linux-8c
 
           - name: armhf-gnu