Refactor: Make AcessMode an enum`

Signed-off-by: Jiahao XU <[email protected]>

Author: NobodyXu

library/std/src/sys/anonymous_pipe/unix.rs

@@ -77,7 +77,7 @@ impl TryFrom<OwnedFd> for PipeReader {
     fn try_from(owned_fd: OwnedFd) -> Result<Self, Self::Error> {
         convert_to_pipe(owned_fd)
             .and_then(|pipe| {
-                if pipe.as_file_desc().get_access_mode()?.readable {
+                if pipe.as_file_desc().get_access_mode()?.is_readable() {
                     Ok(pipe)
                 } else {
                     Err(io::Error::new(
@@ -97,7 +97,7 @@ impl TryFrom<OwnedFd> for PipeWriter {
     fn try_from(owned_fd: OwnedFd) -> Result<Self, Self::Error> {
         convert_to_pipe(owned_fd)
             .and_then(|pipe| {
-                if pipe.as_file_desc().get_access_mode()?.writable {
+                if pipe.as_file_desc().get_access_mode()?.is_writable() {
                     Ok(pipe)
                 } else {
                     Err(io::Error::new(

library/std/src/sys/pal/unix/fd.rs

@@ -26,9 +26,22 @@ use libc::off64_t;
 )))]
 use libc::off_t as off64_t;
 
-pub struct AccessMode {
-    pub readable: bool,
-    pub writable: bool,
+#[derive(Copy, Clone)]
+pub enum AccessMode {
+    ReadOnly,
+    WriteOnly,
+    ReadWrite,
+    None,
+}
+
+impl AccessMode {
+    pub fn is_readable(self) -> bool {
+        matches!(self, AccessMode::ReadOnly | AccessMode::ReadWrite)
+    }
+
+    pub fn is_writable(self) -> bool {
+        matches!(self, AccessMode::WriteOnly | AccessMode::ReadWrite)
+    }
 }
 
 #[derive(Debug)]
@@ -529,9 +542,12 @@ impl FileDesc {
 
     pub fn get_access_mode(&self) -> io::Result<AccessMode> {
         let access_mode = self.get_flags()? & libc::O_ACCMODE;
-        Ok(AccessMode {
-            readable: access_mode == libc::O_RDWR || access_mode == libc::O_RDONLY,
-            writable: access_mode == libc::O_RDWR || access_mode == libc::O_WRONLY,
+        Ok(match access_mode {
+            libc::O_RDWR => AccessMode::ReadWrite,
+            libc::O_RDONLY => AccessMode::ReadOnly,
+            libc::O_WRONLY => AccessMode::WriteOnly,
+
+            _ => AccessMode::None,
         })
     }