-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Search functionality #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yep, I agree this would be nice! This'll probably need to be fixed in mdBook though, and there is an issue over there for it: https://github.com/azerupi/mdBook/issues/51 As a workaround, and I know this isn't ideal, you can click on the printer icon in the upper right which will get you a single-page view and then use ctrl-f. |
Thanks for the workaround, I guess we can close this here then :)
…On Tue 16. May 2017 at 14:26, Carol (Nichols || Goulding) < ***@***.***> wrote:
Yep, I agree this would be nice! This'll probably need to be fixed in
mdBook though, and there is an issue over there for it: azerupi/mdBook#51
<https://github.com/azerupi/mdBook/issues/51>
As a workaround, and I know this isn't ideal, you can click on the printer
icon in the upper right which will get you a single-page view and then use
ctrl-f.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#701 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA3NpthJRmeY6dAS9WKTIiHO_2foXIZ9ks5r6ZX-gaJpZM4NcLIb>
.
|
Ok thanks! |
If it's closed, there's nothing to be blocked...? |
@0joshuaolson1 i don't bother removing labels from issues when i close them... is that what you're commenting about? what is it that's concerning to you? |
No, it's the fact that the upstream issue is still open, so this issue is still a problem. |
@0joshuaolson1 basically, we don't keep issues open when there's nothing for us to do. Once upstream adds the support, we will magically just get it; there's nothing to do in the repository to fix this bug, and so the bug is closed. Open bugs represent work we have to do, and there's no work for us to do in this repo. |
Or use an alternative without such a simple problem. Not sure how viable that is... |
@0joshuaolson1 it is not viable. We are not switching rendering tools at this stage in the process. |
I was trying to find all mentions of arrays in the second edition of the book without any luck. It would be nice if the online-version of the book would have some sort of search capability, where I could just type array and see all chapters that mention them, maybe with a small snippet of the place in which the word is mentioned.
The text was updated successfully, but these errors were encountered: