Skip to content

Search functionality #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnzlbg opened this issue May 16, 2017 · 9 comments
Closed

Search functionality #701

gnzlbg opened this issue May 16, 2017 · 9 comments
Labels
blocked upstream Blocked on a change that needs to happen in a different repo first

Comments

@gnzlbg
Copy link

gnzlbg commented May 16, 2017

I was trying to find all mentions of arrays in the second edition of the book without any luck. It would be nice if the online-version of the book would have some sort of search capability, where I could just type array and see all chapters that mention them, maybe with a small snippet of the place in which the word is mentioned.

@carols10cents
Copy link
Member

Yep, I agree this would be nice! This'll probably need to be fixed in mdBook though, and there is an issue over there for it: https://github.com/azerupi/mdBook/issues/51

As a workaround, and I know this isn't ideal, you can click on the printer icon in the upper right which will get you a single-page view and then use ctrl-f.

@carols10cents carols10cents added the blocked upstream Blocked on a change that needs to happen in a different repo first label May 16, 2017
@gnzlbg
Copy link
Author

gnzlbg commented May 17, 2017 via email

@carols10cents
Copy link
Member

Ok thanks!

@0joshuaolson1
Copy link

If it's closed, there's nothing to be blocked...?

@carols10cents
Copy link
Member

@0joshuaolson1 i don't bother removing labels from issues when i close them... is that what you're commenting about? what is it that's concerning to you?

@0joshuaolson1
Copy link

No, it's the fact that the upstream issue is still open, so this issue is still a problem.

@steveklabnik
Copy link
Member

@0joshuaolson1 basically, we don't keep issues open when there's nothing for us to do.

Once upstream adds the support, we will magically just get it; there's nothing to do in the repository to fix this bug, and so the bug is closed. Open bugs represent work we have to do, and there's no work for us to do in this repo.

@0joshuaolson1
Copy link

Or use an alternative without such a simple problem.

Not sure how viable that is...

@carols10cents
Copy link
Member

@0joshuaolson1 it is not viable. We are not switching rendering tools at this stage in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked upstream Blocked on a change that needs to happen in a different repo first
Projects
None yet
Development

No branches or pull requests

4 participants