fix(new): Catch empty package names earlier

Author: epage

src/cargo/ops/cargo_new.rs

@@ -4,7 +4,7 @@ use crate::util::important_paths::find_root_manifest_for_wd;
 use crate::util::toml_mut::is_sorted;
 use crate::util::{existing_vcs_repo, FossilRepo, GitRepo, HgRepo, PijulRepo};
 use crate::util::{restricted_names, Config};
-use anyhow::{anyhow, Context};
+use anyhow::{anyhow, bail, Context};
 use cargo_util::paths::{self, write_atomic};
 use serde::de;
 use serde::Deserialize;
@@ -197,6 +197,9 @@ fn check_name(
         }
         help
     };
+    if name.is_empty() {
+        bail!("package name cannot be empty");
+    }
     restricted_names::validate_package_name(name, "package name", &bin_help())?;
 
     if restricted_names::is_keyword(name) {

tests/testsuite/cargo_new/empty_name/mod.rs

@@ -14,7 +14,7 @@ fn case() {
         .args(["foo", "--name", ""])
         .current_dir(cwd)
         .assert()
-        .success()
+        .failure()
         .stdout_matches_path(curr_dir!().join("stdout.log"))
         .stderr_matches_path(curr_dir!().join("stderr.log"));
 

tests/testsuite/cargo_new/empty_name/stderr.log

@@ -1,7 +1 @@
-warning: compiling this new package may not work due to invalid workspace configuration
-
-failed to parse manifest at `[ROOT]/case/foo/Cargo.toml`
-
-Caused by:
-  package name cannot be an empty string
-     Created binary (application) `` package
+error: package name cannot be empty