Use Array::sort_by to sort the members list.

Signed-off-by: David Calavera <[email protected]>

Author: calavera

Cargo.lock

@@ -92,7 +92,7 @@ tempfile = "3.8.0"
 thiserror = "1.0.49"
 time = { version = "0.3", features = ["parsing", "formatting", "serde"] }
 toml = "0.8.2"
-toml_edit = { version = "0.20.2", features = ["serde"] }
+toml_edit = { version = "0.20.7", features = ["serde"] }
 tracing = "0.1.37"
 tracing-subscriber = { version = "0.3.17", features = ["env-filter"] }
 unicase = "2.7.0"

Cargo.toml

@@ -996,11 +996,11 @@ fn update_manifest_with_new_member(
     // - Add the relative path if the members don't match the new package's path.
     // - Create a new members array if there are no members element in the workspace yet.
     if let Some(members) = workspace_document
-        .get("workspace")
-        .and_then(|workspace| workspace.get("members"))
-        .and_then(|members| members.as_array())
+        .get_mut("workspace")
+        .and_then(|workspace| workspace.get_mut("members"))
+        .and_then(|members| members.as_array_mut())
     {
-        for member in members {
+        for member in members.iter() {
             let pat = member
                 .as_str()
                 .with_context(|| format!("invalid non-string member `{}`", member))?;
@@ -1012,14 +1012,11 @@ fn update_manifest_with_new_member(
             }
         }
 
-        let was_sorted = is_sorted(members.iter().filter_map(Value::as_str));
-        let mut values: Vec<&str> = members.iter().filter_map(Value::as_str).collect();
-        values.push(&display_path);
+        let was_sorted = is_sorted(members.iter().map(Value::as_str));
+        members.push(&display_path);
         if was_sorted {
-            values.sort();
+            members.sort_by(|lhs, rhs| lhs.as_str().cmp(&rhs.as_str()));
         }
-        let array = Array::from_iter(values);
-        workspace_document["workspace"]["members"] = toml_edit::value(array);
     } else {
         let mut array = Array::new();
         array.push(&display_path);