Add tests showing incorrect workspace packaging.

Author: jneem

tests/testsuite/package.rs

@@ -7,7 +7,7 @@ use cargo_test_support::publish::validate_crate_contents;
 use cargo_test_support::registry::{self, Package};
 use cargo_test_support::{
     basic_manifest, cargo_process, git, path2url, paths, project, rustc_host, symlink_supported, t,
-    ProjectBuilder,
+    Project, ProjectBuilder,
 };
 use flate2::read::GzDecoder;
 use std::fs::{self, read_to_string, File};
@@ -5038,3 +5038,303 @@ path = "examples/z.rs"
         )],
     );
 }
+
+#[cargo_test]
+fn workspace_with_local_deps() {
+    let crates_io = registry::init();
+    let p = build_workspace_with_local_deps(None);
+
+    p.cargo("package")
+        .replace_crates_io(crates_io.index_url())
+        .with_status(101)
+        .with_stdout("")
+        .with_stderr(
+            "\
+[PACKAGING] level1 v0.0.1 ([CWD]/level1)
+[UPDATING] crates.io index
+error: failed to prepare local package for uploading
+
+Caused by:
+  no matching package named `level2` found
+  location searched: registry `crates-io`
+  required by package `level1 v0.0.1 [..]
+",
+        )
+        .run();
+}
+
+#[cargo_test]
+fn workspace_with_local_deps_packaging_one_fails() {
+    let crates_io = registry::init();
+    let p = build_workspace_with_local_deps(None);
+
+    p.cargo("package -p level2")
+        .replace_crates_io(crates_io.index_url())
+        .with_status(101)
+        .with_stdout("")
+        .with_stderr(
+            "\
+[PACKAGING] level2 v0.0.1 ([CWD]/level2)
+[PACKAGED] 3 files, [..] ([..] compressed)
+[VERIFYING] level2 v0.0.1 ([CWD]/level2)
+[UPDATING] crates.io index
+[ERROR] failed to verify package tarball
+
+Caused by:
+  no matching package named `level3` found
+  location searched: registry `crates-io`
+  required by package `level2 v0.0.1 ([CWD]/target/package/level2-0.0.1)`
+",
+        )
+        .run();
+}
+
+#[cargo_test]
+fn workspace_with_local_deps_packaging_one_with_needed_deps() {
+    let crates_io = registry::init();
+    let p = build_workspace_with_local_deps(None);
+
+    p.cargo("package -p level2 -p level3")
+        .replace_crates_io(crates_io.index_url())
+        .with_status(101)
+        .with_stdout("")
+        .with_stderr(
+            "\
+[PACKAGING] level2 v0.0.1 ([CWD]/level2)
+[PACKAGED] 3 files, [..] ([..] compressed)
+[VERIFYING] level2 v0.0.1 ([CWD]/level2)
+[UPDATING] crates.io index
+[ERROR] failed to verify package tarball
+
+Caused by:
+  no matching package named `level3` found
+  location searched: registry `crates-io`
+  required by package `level2 v0.0.1 [..]
+",
+        )
+        .run();
+}
+
+#[cargo_test]
+fn workspace_with_local_deps_list() {
+    let crates_io = registry::init();
+    let p = build_workspace_with_local_deps(None);
+
+    p.cargo("package --list")
+        .replace_crates_io(crates_io.index_url())
+        .with_stdout(
+            // This looks like it could be improved. See
+            // https://github.com/rust-lang/cargo/issues/13953
+            "\
+Cargo.lock
+Cargo.toml
+Cargo.toml.orig
+src/main.rs
+Cargo.toml
+Cargo.toml.orig
+src/lib.rs
+Cargo.toml
+Cargo.toml.orig
+src/lib.rs
+",
+        )
+        .with_stderr("")
+        .run();
+}
+
+#[cargo_test]
+fn workspace_with_local_deps_index_mismatch() {
+    let alt_reg = registry::RegistryBuilder::new()
+        .http_api()
+        .http_index()
+        .alternative()
+        .build();
+    // We're publishing to an alternate index, but the manifests don't specify it.
+    // The intra-workspace deps won't be found.
+    let p = build_workspace_with_local_deps(None);
+    p.cargo(&format!("package --index {}", alt_reg.index_url()))
+        .with_status(1)
+        .with_stdout("")
+        .with_stderr(
+            "\
+error: unexpected argument '--index' found
+
+Usage: cargo package [OPTIONS]
+
+For more information, try '--help'.
+",
+        )
+        .run();
+}
+
+#[cargo_test]
+fn workspace_with_local_deps_alternative_index() {
+    let alt_reg = registry::RegistryBuilder::new()
+        .http_api()
+        .http_index()
+        .alternative()
+        .build();
+    let p = build_workspace_with_local_deps(Some("alternative"));
+
+    p.cargo(&format!("package --index {}", alt_reg.index_url()))
+        .with_status(1)
+        .with_stdout("")
+        .with_stderr(
+            "\
+error: unexpected argument '--index' found
+
+Usage: cargo package [OPTIONS]
+
+For more information, try '--help'.
+",
+        )
+        .run();
+}
+
+/// level1 -> level2 checks that we handle local dependencies.
+/// level2 -> level3 checks that we handle dependencies with local dependencies.
+fn build_workspace_with_local_deps(registry: Option<&str>) -> Project {
+    let registry = match registry {
+        Some(r) => format!(r#", registry = "{r}""#),
+        None => "".to_owned(),
+    };
+    project()
+        .file(
+            "Cargo.toml",
+            &format!(r#"
+            [workspace]
+            members = ["level1", "level2", "level3"]
+
+            # Let one of the deps be inherited from the workspace, for the added test coverage when resolving.
+            [workspace.dependencies]
+            level2 = {{ path = "level2", version = "0.0.1" {registry} }}
+        "#),
+        )
+        .file(
+            "level1/Cargo.toml",
+            r#"
+            [package]
+            name = "level1"
+            version = "0.0.1"
+            edition = "2015"
+            authors = []
+            license = "MIT"
+            description = "level1"
+            repository = "bar"
+
+            [dependencies]
+            # Let one dependency also specify features, for the added test coverage when generating package files.
+            level2 = { workspace = true, features = ["foo"] }
+        "#,
+        )
+        .file("level1/src/main.rs", "fn main() {}")
+        .file(
+            "level2/Cargo.toml",
+            &format!(r#"
+            [package]
+            name = "level2"
+            version = "0.0.1"
+            edition = "2015"
+            authors = []
+            license = "MIT"
+            description = "level2"
+            repository = "bar"
+
+            [features]
+            foo = []
+
+            [dependencies]
+            level3 = {{ path = "../level3", version = "0.0.1" {registry} }}
+        "#),
+        )
+        .file("level2/src/lib.rs", "")
+        .file(
+            "level3/Cargo.toml",
+            r#"
+            [package]
+            name = "level3"
+            version = "0.0.1"
+            edition = "2015"
+            authors = []
+            license = "MIT"
+            description = "level3"
+            repository = "bar"
+        "#,
+        )
+        .file("level3/src/lib.rs", "")
+        .build()
+}
+
+#[cargo_test]
+fn workspace_with_local_and_remote_deps() {
+    let reg = registry::init();
+
+    Package::new("dep", "0.0.1").publish();
+
+    let p = project()
+        .file(
+            "Cargo.toml",
+            r#"
+            [workspace]
+            members = ["dep", "main"]
+            "#,
+        )
+        .file(
+            "main/Cargo.toml",
+            r#"
+            [package]
+            name = "main"
+            version = "0.0.1"
+            edition = "2015"
+            authors = []
+            license = "MIT"
+            description = "main"
+            repository = "bar"
+
+            [dependencies]
+            dep = { path = "../dep", version = "0.1.0" }
+            old_dep = { package = "dep", version = "0.0.1" }
+        "#,
+        )
+        .file("main/src/main.rs", "fn main() {}")
+        .file(
+            "dep/Cargo.toml",
+            &format!(
+                r#"
+            [package]
+            name = "dep"
+            version = "0.1.0"
+            edition = "2015"
+            authors = []
+            license = "MIT"
+            description = "dep"
+            repository = "bar"
+        "#
+            ),
+        )
+        .file("dep/src/lib.rs", "")
+        .build();
+
+    p.cargo("package")
+        .replace_crates_io(reg.index_url())
+        .with_status(101)
+        .with_stderr(
+            "\
+[PACKAGING] dep v0.1.0 ([CWD]/dep)
+[PACKAGED] 3 files, [..] ([..] compressed)
+[VERIFYING] dep v0.1.0 ([CWD]/dep)
+[COMPILING] dep v0.1.0 ([..])
+[FINISHED] [..]
+[PACKAGING] main v0.0.1 ([CWD]/main)
+[UPDATING] crates.io index
+[ERROR] failed to prepare local package for uploading
+
+Caused by:
+  failed to select a version for the requirement `dep = \"^0.1.0\"`
+  candidate versions found which didn't match: 0.0.1
+  location searched: crates.io index
+  required by package `main v0.0.1 [..]`
+",
+        )
+        .run();
+}