test: fix sat resolver panic if a dep feature is missing

Author: x-hgg-x

crates/resolver-tests/src/sat.rs

@@ -118,25 +118,32 @@ fn process_pkg_features(
                     dep_feature: dep_feature_name,
                     weak,
                 } => {
+                    let mut dep_clause = Vec::new();
+
                     for dep in &compatible_dep_summaries_by_name_in_toml[&dep_name] {
+                        let dep_feature_var_map =
+                            &var_for_is_packages_features_used[&dep.package_id()];
+
+                        let Some(dep_feature_var) = dep_feature_var_map.get(&dep_feature_name)
+                        else {
+                            continue;
+                        };
+
                         let dep_var = var_for_is_packages_used[&dep.package_id()];
-                        let dep_feature_var =
-                            var_for_is_packages_features_used[&dep.package_id()][&dep_feature_name];
 
                         solver.add_clause(&[
                             pkg_feature_var.negative(),
                             dep_var.negative(),
                             dep_feature_var.positive(),
                         ]);
+
+                        if !weak {
+                            dep_clause.push(dep_var.positive());
+                        }
                     }
 
                     if !weak {
-                        let dep_clause = compatible_dep_summaries_by_name_in_toml[&dep_name]
-                            .iter()
-                            .map(|dep| var_for_is_packages_used[&dep.package_id()].positive())
-                            .chain([pkg_feature_var.negative()])
-                            .collect::<Vec<_>>();
-
+                        dep_clause.push(pkg_feature_var.negative());
                         solver.add_clause(&dep_clause);
                     }
                 }

crates/resolver-tests/tests/validated.rs

@@ -165,6 +165,18 @@ fn missing_feature() {
     assert!(resolve_and_validated(vec!["a".with(&["f"])], &reg, &mut sat_resolver).is_err());
 }
 
+#[test]
+fn missing_dep_feature() {
+    let reg = registry(vec![
+        pkg("a"),
+        pkg_dep_with("dep", vec![dep("a")], &[("f", &["a/a"])]),
+    ]);
+
+    let deps = vec![dep("dep").with(&["f"])];
+    let mut sat_resolver = SatResolver::new(&reg);
+    assert!(resolve_and_validated(deps, &reg, &mut sat_resolver).is_err());
+}
+
 #[test]
 fn conflict_feature_and_sys() {
     let reg = registry(vec![