Use try! instead of CliError::from_boxed

This From impl has been around for awhile.

Author: alexcrichton

src/bin/bench.rs

@@ -89,10 +89,7 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<()>> {
         },
     };
 
-    let err = try!(ops::run_benches(&root, &ops,
-                                    &options.arg_args).map_err(|err| {
-        CliError::from_boxed(err, 101)
-    }));
+    let err = try!(ops::run_benches(&root, &ops, &options.arg_args));
     match err {
         None => Ok(None),
         Some(err) => {

src/bin/build.rs

@@ -3,7 +3,7 @@ use std::env;
 use cargo::ops::CompileOptions;
 use cargo::ops;
 use cargo::util::important_paths::{find_root_manifest_for_wd};
-use cargo::util::{CliResult, CliError, Config};
+use cargo::util::{CliResult, Config};
 
 #[derive(RustcDecodable)]
 struct Options {
@@ -85,7 +85,6 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<()>> {
         target_rustc_args: None,
     };
 
-    ops::compile(&root, &opts).map(|_| None).map_err(|err| {
-        CliError::from_boxed(err, 101)
-    })
+    try!(ops::compile(&root, &opts));
+    Ok(None)
 }

src/bin/clean.rs

@@ -1,7 +1,7 @@
 use std::env;
 
 use cargo::ops;
-use cargo::util::{CliResult, CliError, Config};
+use cargo::util::{CliResult, Config};
 use cargo::util::important_paths::{find_root_manifest_for_wd};
 
 #[derive(RustcDecodable)]
@@ -49,7 +49,6 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<()>> {
         target: options.flag_target.as_ref().map(|s| &s[..]),
         release: options.flag_release,
     };
-    ops::clean(&root, &opts).map(|_| None).map_err(|err| {
-      CliError::from_boxed(err, 101)
-    })
+    try!(ops::clean(&root, &opts));
+    Ok(None)
 }

src/bin/doc.rs

@@ -1,5 +1,5 @@
 use cargo::ops;
-use cargo::util::{CliResult, CliError, Config};
+use cargo::util::{CliResult, Config};
 use cargo::util::important_paths::{find_root_manifest_for_wd};
 
 #[derive(RustcDecodable)]
@@ -74,9 +74,6 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<()>> {
         },
     };
 
-    try!(ops::doc(&root, &doc_opts).map_err(|err| {
-        CliError::from_boxed(err, 101)
-    }));
-
+    try!(ops::doc(&root, &doc_opts));
     Ok(None)
 }

src/bin/fetch.rs

@@ -1,5 +1,5 @@
 use cargo::ops;
-use cargo::util::{CliResult, CliError, Config};
+use cargo::util::{CliResult, Config};
 use cargo::util::important_paths::find_root_manifest_for_wd;
 
 #[derive(RustcDecodable)]
@@ -37,9 +37,7 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<()>> {
     try!(config.shell().set_verbosity(options.flag_verbose, options.flag_quiet));
     try!(config.shell().set_color_config(options.flag_color.as_ref().map(|s| &s[..])));
     let root = try!(find_root_manifest_for_wd(options.flag_manifest_path, config.cwd()));
-    try!(ops::fetch(&root, config).map_err(|e| {
-        CliError::from_boxed(e, 101)
-    }));
+    try!(ops::fetch(&root, config));
     Ok(None)
 }
 

src/bin/generate_lockfile.rs

@@ -1,7 +1,7 @@
 use std::env;
 
 use cargo::ops;
-use cargo::util::{CliResult, CliError, Config};
+use cargo::util::{CliResult, Config};
 use cargo::util::important_paths::find_root_manifest_for_wd;
 
 #[derive(RustcDecodable)]
@@ -32,6 +32,6 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<()>> {
     try!(config.shell().set_color_config(options.flag_color.as_ref().map(|s| &s[..])));
     let root = try!(find_root_manifest_for_wd(options.flag_manifest_path, config.cwd()));
 
-    ops::generate_lockfile(&root, config)
-        .map(|_| None).map_err(|err| CliError::from_boxed(err, 101))
+    try!(ops::generate_lockfile(&root, config));
+    Ok(None)
 }

src/bin/login.rs

@@ -4,7 +4,7 @@ use std::io;
 use cargo::ops;
 use cargo::core::{SourceId, Source};
 use cargo::sources::RegistrySource;
-use cargo::util::{CliResult, CliError, Config};
+use cargo::util::{CliResult, Config, human, ChainError};
 
 #[derive(RustcDecodable)]
 struct Options {
@@ -36,28 +36,23 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<()>> {
     let token = match options.arg_token.clone() {
         Some(token) => token,
         None => {
-            let err = (|| {
-                let src = try!(SourceId::for_central(config));
-                let mut src = RegistrySource::new(&src, config);
-                try!(src.update());
-                let config = try!(src.config());
-                let host = options.flag_host.clone().unwrap_or(config.api);
-                println!("please visit {}me and paste the API Token below",
-                         host);
-                let mut line = String::new();
-                let input = io::stdin();
-                try!(input.lock().read_line(&mut line));
-                Ok(line)
-            })();
-
-            try!(err.map_err(|e| CliError::from_boxed(e, 101)))
+            let src = try!(SourceId::for_central(config));
+            let mut src = RegistrySource::new(&src, config);
+            try!(src.update());
+            let config = try!(src.config());
+            let host = options.flag_host.clone().unwrap_or(config.api);
+            println!("please visit {}me and paste the API Token below", host);
+            let mut line = String::new();
+            let input = io::stdin();
+            try!(input.lock().read_line(&mut line).chain_error(|| {
+                human("failed to read stdin")
+            }));
+            line
         }
     };
 
     let token = token.trim().to_string();
-    try!(ops::registry_login(config, token).map_err(|e| {
-        CliError::from_boxed(e, 101)
-    }));
+    try!(ops::registry_login(config, token));
     Ok(None)
 }
 

src/bin/new.rs

@@ -1,7 +1,7 @@
 use std::env;
 
 use cargo::ops;
-use cargo::util::{CliResult, CliError, Config};
+use cargo::util::{CliResult, Config};
 
 #[derive(RustcDecodable)]
 struct Options {
@@ -47,8 +47,7 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<()>> {
         name: flag_name.as_ref().map(|s| s.as_ref()),
     };
 
-    ops::new(opts, config).map(|_| None).map_err(|err| {
-        CliError::from_boxed(err, 101)
-    })
+    try!(ops::new(opts, config));
+    Ok(None)
 }
 

src/bin/owner.rs

@@ -1,5 +1,5 @@
 use cargo::ops;
-use cargo::util::{CliResult, CliError, Config};
+use cargo::util::{CliResult, Config};
 
 #[derive(RustcDecodable)]
 struct Options {
@@ -51,9 +51,7 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<()>> {
         to_remove: options.flag_remove,
         list: options.flag_list,
     };
-    try!(ops::modify_owners(config, &opts).map_err(|e| {
-        CliError::from_boxed(e, 101)
-    }));
+    try!(ops::modify_owners(config, &opts));
     Ok(None)
 }
 

src/bin/package.rs

@@ -1,5 +1,5 @@
 use cargo::ops;
-use cargo::util::{CliResult, CliError, Config};
+use cargo::util::{CliResult, Config};
 use cargo::util::important_paths::find_root_manifest_for_wd;
 
 #[derive(RustcDecodable)]
@@ -35,10 +35,9 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<()>> {
     try!(config.shell().set_verbosity(options.flag_verbose, options.flag_quiet));
     try!(config.shell().set_color_config(options.flag_color.as_ref().map(|s| &s[..])));
     let root = try!(find_root_manifest_for_wd(options.flag_manifest_path, config.cwd()));
-    ops::package(&root, config,
-                 !options.flag_no_verify,
-                 options.flag_list,
-                 !options.flag_no_metadata).map(|_| None).map_err(|err| {
-        CliError::from_boxed(err, 101)
-    })
+    try!(ops::package(&root, config,
+                      !options.flag_no_verify,
+                      options.flag_list,
+                      !options.flag_no_metadata));
+    Ok(None)
 }

src/bin/pkgid.rs

@@ -1,5 +1,5 @@
 use cargo::ops;
-use cargo::util::{CliResult, CliError, Config};
+use cargo::util::{CliResult, Config};
 use cargo::util::important_paths::{find_root_manifest_for_wd};
 
 #[derive(RustcDecodable)]
@@ -52,9 +52,7 @@ pub fn execute(options: Options,
     let root = try!(find_root_manifest_for_wd(options.flag_manifest_path.clone(), config.cwd()));
 
     let spec = options.arg_spec.as_ref().map(|s| &s[..]);
-    let spec = try!(ops::pkgid(&root, spec, config).map_err(|err| {
-      CliError::from_boxed(err, 101)
-    }));
+    let spec = try!(ops::pkgid(&root, spec, config));
     println!("{}", spec);
     Ok(None)
 }

src/bin/publish.rs

@@ -1,5 +1,5 @@
 use cargo::ops;
-use cargo::util::{CliResult, CliError, Config};
+use cargo::util::{CliResult, Config};
 use cargo::util::important_paths::find_root_manifest_for_wd;
 
 #[derive(RustcDecodable)]
@@ -43,7 +43,6 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<()>> {
     } = options;
 
     let root = try!(find_root_manifest_for_wd(flag_manifest_path.clone(), config.cwd()));
-    ops::publish(&root, config, token, host, !no_verify).map(|_| None).map_err(|err| {
-        CliError::from_boxed(err, 101)
-    })
+    try!(ops::publish(&root, config, token, host, !no_verify));
+    Ok(None)
 }

src/bin/read_manifest.rs

@@ -2,7 +2,7 @@ use std::env;
 use std::error::Error;
 
 use cargo::core::{Package, Source};
-use cargo::util::{CliResult, CliError, Config};
+use cargo::util::{CliResult, Config};
 use cargo::util::important_paths::{find_root_manifest_for_wd};
 use cargo::sources::{PathSource};
 
@@ -31,13 +31,9 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<Package>>
 
     let root = try!(find_root_manifest_for_wd(options.flag_manifest_path, config.cwd()));
 
-    let mut source = try!(PathSource::for_path(root.parent().unwrap(), config).map_err(|e| {
-        CliError::new(e.description(), 1)
-    }));
+    let mut source = try!(PathSource::for_path(root.parent().unwrap(), config));
+    try!(source.update());
 
-    try!(source.update().map_err(|err| CliError::new(err.description(), 1)));
-
-    source.root_package()
-          .map(Some)
-          .map_err(|err| CliError::from_boxed(err, 1))
+    let pkg = try!(source.root_package());
+    Ok(Some(pkg))
 }

src/bin/rustc.rs

@@ -3,7 +3,7 @@ use std::env;
 use cargo::ops::CompileOptions;
 use cargo::ops;
 use cargo::util::important_paths::{find_root_manifest_for_wd};
-use cargo::util::{CliResult, CliError, Config};
+use cargo::util::{CliResult, Config};
 
 #[derive(RustcDecodable)]
 struct Options {
@@ -89,8 +89,7 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<()>> {
         target_rustc_args: options.arg_opts.as_ref().map(|a| &a[..]),
     };
 
-    ops::compile(&root, &opts).map(|_| None).map_err(|err| {
-        CliError::from_boxed(err, 101)
-    })
+    try!(ops::compile(&root, &opts));
+    Ok(None)
 }
 

src/bin/search.rs

@@ -1,5 +1,5 @@
 use cargo::ops;
-use cargo::util::{CliResult, CliError, Config};
+use cargo::util::{CliResult, Config};
 
 #[derive(RustcDecodable)]
 struct Options {
@@ -34,7 +34,6 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<()>> {
         ..
     } = options;
 
-    ops::search(&query, config, host)
-        .map(|_| None)
-        .map_err(|err| CliError::from_boxed(err, 101))
+    try!(ops::search(&query, config, host));
+    Ok(None)
 }

src/bin/test.rs

@@ -95,10 +95,7 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<()>> {
         },
     };
 
-    let err = try!(ops::run_tests(&root, &ops,
-                                  &options.arg_args).map_err(|err| {
-        CliError::from_boxed(err, 101)
-    }));
+    let err = try!(ops::run_tests(&root, &ops, &options.arg_args));
     match err {
         None => Ok(None),
         Some(err) => {

src/bin/update.rs

@@ -1,7 +1,7 @@
 use std::env;
 
 use cargo::ops;
-use cargo::util::{CliResult, CliError, Config};
+use cargo::util::{CliResult, Config};
 use cargo::util::important_paths::find_root_manifest_for_wd;
 
 #[derive(RustcDecodable)]
@@ -65,7 +65,7 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<()>> {
         config: config,
     };
 
-    ops::update_lockfile(&root, &update_opts)
-        .map(|_| None).map_err(|err| CliError::from_boxed(err, 101))
+    try!(ops::update_lockfile(&root, &update_opts));
+    Ok(None)
 }
 

src/bin/yank.rs

@@ -1,5 +1,5 @@
 use cargo::ops;
-use cargo::util::{CliResult, CliError, Config};
+use cargo::util::{CliResult, Config};
 
 #[derive(RustcDecodable)]
 struct Options {
@@ -46,9 +46,7 @@ pub fn execute(options: Options, config: &Config) -> CliResult<Option<()>> {
                    options.flag_vers,
                    options.flag_token,
                    options.flag_index,
-                   options.flag_undo).map_err(|e| {
-        CliError::from_boxed(e, 101)
-    }));
+                   options.flag_undo));
     Ok(None)
 }