Skip to content

cargo fix won't fix double-error of crate renamed to reserved identier #5827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cramertj opened this issue Jul 28, 2018 · 2 comments
Closed

Comments

@cramertj
Copy link
Member

This is particularly pathological and might be to the point of "wontfix", but in fuchsia prior to edition 2018 we had a crate called "fuchsia_async" that we would commonly import as "extern crate fuchsia_async as async;", and could then use from other files in the same crate as "async::...". cargo fix fails on these examples. I'd expect it to do something like async::T -> r#async::T -> crate::r#async::T, but it just outputs a warning instead.

Note: this is with #![feature(raw_identifiers, crate_in_paths)].

@Mark-Simulacrum
Copy link
Member

I believe we currently revert changes we've made if the crate still had warnings on the second compile, though I might be remembering wrong.

@alexcrichton
Copy link
Member

Thanks for the report! This certainly isn't the only example of what we have to deal with here, there's also things like ::local_path::<::LocalType>(). A solution in cargo fix for this is being tracked at #5813, so I'm gonna close this in favor of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants