Skip to content
This repository was archived by the owner on Mar 14, 2023. It is now read-only.

Commit bbf7b20

Browse files
committed
Add reminder about review in welcome msg
1 parent 767cd4a commit bbf7b20

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

highfive/newpr.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
raw_welcome = """Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from %s soon.
2424
2525
Please see [the contribution instructions](%s) for more information.
26+
27+
Tip: when your PR is ready for review, don't forget to fire up the command `@rustbot ready` to put your PR in the review queue of your assigned reviewer: this will help speed up the overall review process.
2628
"""
2729

2830
warning_summary = ':warning: **Warning** :warning:\n\n%s'

highfive/tests/test_integration_tests.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ def test_new_pr_non_contributor(self):
103103
(
104104
'POST', newpr.post_comment_url % ('rust-lang', 'rust', '7'),
105105
{
106-
'body': "Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.\n\nPlease see [the contribution instructions](https://rustc-dev-guide.rust-lang.org/contributing.html) for more information.\n"}
106+
'body': "Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.\n\nPlease see [the contribution instructions](https://rustc-dev-guide.rust-lang.org/contributing.html) for more information.\n\nTip: when your PR is ready for review, don't forget to fire up the command `@rustbot ready` to put your PR in the review queue of your assigned reviewer: this will help speed up the overall review process.\n"}
107107
),
108108
{'body': {}},
109109
),
@@ -145,7 +145,7 @@ def test_new_pr_empty_body(self):
145145
(
146146
'POST', newpr.post_comment_url % ('rust-lang', 'rust', '7'),
147147
{
148-
'body': "Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.\n\nPlease see [the contribution instructions](https://rustc-dev-guide.rust-lang.org/contributing.html) for more information.\n"}
148+
'body': "Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.\n\nPlease see [the contribution instructions](https://rustc-dev-guide.rust-lang.org/contributing.html) for more information.\n\nTip: when your PR is ready for review, don't forget to fire up the command `@rustbot ready` to put your PR in the review queue of your assigned reviewer: this will help speed up the overall review process.\n"}
149149
),
150150
{'body': {}},
151151
),

highfive/tests/test_newpr.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,8 @@ def test_welcome_msg(self):
113113
base_msg = """Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from %s soon.
114114
115115
Please see [the contribution instructions](%s) for more information.
116+
117+
Tip: when your PR is ready for review, don't forget to fire up the command `@rustbot ready` to put your PR in the review queue of your assigned reviewer: this will help speed up the overall review process.
116118
"""
117119

118120
# No reviewer, no config contributing link.

0 commit comments

Comments
 (0)