Skip to content

Commit 4bedb67

Browse files
committed
Update comment about approval note-to-self
Update the comment on the Approved comment to explain why there is a note-to-self `@bors r=approver {full_commit_hash}` command.
1 parent 889aedf commit 4bedb67

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

homu/comments.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,10 @@ def __init__(self, bot=None, **args):
3131
params = ["sha", "approver"]
3232

3333
def render(self):
34-
# The comment here is apparently required because Homu seems to use
35-
# this note-to-self comment to kick off the build. Presumably because
36-
# it contains the full commit hash?
34+
# The comment here is required because Homu wants a full, unambiguous,
35+
# pinned commit hash to kick off the build, and this note-to-self is
36+
# how it gets it. This is to safeguard against situations where Homu
37+
# reloads and another commit has been pushed since the approval.
3738
message = ":pushpin: Commit {sha} has been " + \
3839
"approved by `{approver}`\n\n" + \
3940
"<!-- @{bot} r={approver} {sha} -->"

0 commit comments

Comments
 (0)