Merge pull request #4489 from tgross35/lint-fixes

Allow new `unpredictable_function_pointer_comparisons` lints

Author: tgross35

src/fuchsia/mod.rs

@@ -292,6 +292,8 @@ s! {
         __dummy4: [c_char; 16],
     }
 
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/bsd/freebsdlike/dragonfly/mod.rs

@@ -520,6 +520,8 @@ s_no_extra_traits! {
         pub mc_fpregs: [c_uint; 256],
     }
 
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct ucontext_t {
         pub uc_sigmask: crate::sigset_t,
         pub uc_mcontext: mcontext_t,

src/unix/bsd/freebsdlike/freebsd/mod.rs

@@ -237,6 +237,8 @@ impl Clone for devstat_select_mode {
 }
 
 s! {
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct __c_anonymous_sigev_thread {
         pub _function: Option<extern "C" fn(crate::sigval) -> *mut c_void>,
         //pub _function: *mut c_void, // Actually a function pointer

src/unix/cygwin/mod.rs

@@ -351,6 +351,8 @@ s! {
         pub cr2: u64,
     }
 
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigevent {
         pub sigev_value: sigval,
         pub sigev_signo: c_int,

src/unix/haiku/native.rs

@@ -403,11 +403,14 @@ s! {
     }
 
     // kernel/image.h
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct image_info {
         pub id: image_id,
         pub image_type: c_int,
         pub sequence: i32,
         pub init_order: i32,
+        // FIXME(1.0): these should be made optional
         pub init_routine: extern "C" fn(),
         pub term_routine: extern "C" fn(),
         pub device: crate::dev_t,

src/unix/linux_like/android/b32/mod.rs

@@ -12,6 +12,8 @@ pub type __u64 = c_ulonglong;
 pub type __s64 = c_longlong;
 
 s! {
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/linux_like/android/b64/mod.rs

@@ -12,6 +12,8 @@ s! {
         __val: [c_ulong; 1],
     }
 
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_flags: c_int,
         pub sa_sigaction: crate::sighandler_t,

src/unix/linux_like/emscripten/mod.rs

@@ -158,6 +158,8 @@ s! {
         pub sem_flg: c_short,
     }
 
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/linux_like/linux/gnu/b32/arm/mod.rs

@@ -4,6 +4,8 @@ use crate::{off64_t, off_t};
 pub type wchar_t = u32;
 
 s! {
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/linux_like/linux/gnu/b32/csky/mod.rs

@@ -4,6 +4,8 @@ use crate::{off64_t, off_t};
 pub type wchar_t = u32;
 
 s! {
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/linux_like/linux/gnu/b32/m68k/mod.rs

@@ -4,6 +4,8 @@ use crate::{off64_t, off_t};
 pub type wchar_t = i32;
 
 s! {
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/linux_like/linux/gnu/b32/mips/mod.rs

@@ -163,6 +163,8 @@ s! {
         __f_spare: [c_int; 6],
     }
 
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_flags: c_int,
         pub sa_sigaction: crate::sighandler_t,

src/unix/linux_like/linux/gnu/b32/powerpc.rs

@@ -4,6 +4,8 @@ use crate::{off64_t, off_t};
 pub type wchar_t = i32;
 
 s! {
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/linux_like/linux/gnu/b32/riscv32/mod.rs

@@ -108,6 +108,8 @@ s! {
         pub ss_size: size_t,
     }
 
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/linux_like/linux/gnu/b32/sparc/mod.rs

@@ -6,6 +6,8 @@ use crate::{off64_t, off_t};
 pub type wchar_t = i32;
 
 s! {
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/linux_like/linux/gnu/b32/x86/mod.rs

@@ -5,6 +5,8 @@ pub type wchar_t = i32;
 pub type greg_t = i32;
 
 s! {
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/linux_like/linux/gnu/b64/aarch64/mod.rs

@@ -11,6 +11,8 @@ pub type __u64 = c_ulonglong;
 pub type __s64 = c_longlong;
 
 s! {
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/linux_like/linux/gnu/b64/loongarch64/mod.rs

@@ -134,6 +134,8 @@ s! {
         __size: [c_ulong; 7],
     }
 
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/linux_like/linux/gnu/b64/mips64/mod.rs

@@ -136,6 +136,8 @@ s! {
         __size: [c_ulong; 7],
     }
 
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_flags: c_int,
         pub sa_sigaction: crate::sighandler_t,

src/unix/linux_like/linux/gnu/b64/powerpc64/mod.rs

@@ -11,6 +11,8 @@ pub type __u64 = c_ulong;
 pub type __s64 = c_long;
 
 s! {
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/linux_like/linux/gnu/b64/riscv64/mod.rs

@@ -143,6 +143,8 @@ s! {
         pub ss_size: size_t,
     }
 
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/linux_like/linux/gnu/b64/s390x.rs

@@ -12,6 +12,8 @@ pub type __u64 = u64;
 pub type __s64 = i64;
 
 s! {
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         __glibc_reserved0: c_int,

src/unix/linux_like/linux/gnu/b64/sparc64/mod.rs

@@ -11,6 +11,8 @@ pub type __u64 = c_ulonglong;
 pub type __s64 = c_longlong;
 
 s! {
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/linux_like/linux/gnu/b64/x86_64/mod.rs

@@ -12,6 +12,8 @@ pub type __u64 = c_ulonglong;
 pub type __s64 = c_longlong;
 
 s! {
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/linux_like/linux/musl/mod.rs

@@ -122,6 +122,8 @@ impl siginfo_t {
 }
 
 s! {
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_mask: crate::sigset_t,

src/unix/linux_like/linux/uclibc/arm/mod.rs

@@ -163,6 +163,8 @@ s! {
         __val: [c_ulong; 2],
     }
 
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_flags: c_ulong,

src/unix/linux_like/linux/uclibc/x86_64/mod.rs

@@ -132,6 +132,8 @@ s! {
         st_pad4: [c_long; 3],
     }
 
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_handler: crate::sighandler_t,
         pub sa_flags: c_ulong,

src/unix/linux_like/mod.rs

@@ -14,6 +14,8 @@ missing! {
 }
 
 s! {
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct __c_anonymous_sigev_thread {
         pub _function: Option<extern "C" fn(crate::sigval) -> *mut c_void>,
         pub _attribute: *mut crate::pthread_attr_t,

src/unix/nto/mod.rs

@@ -576,6 +576,8 @@ s! {
         re_g: *mut c_void,
     }
 
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct _thread_attr {
         pub __flags: c_int,
         pub __stacksize: size_t,

src/unix/nto/neutrino.rs

@@ -137,6 +137,8 @@ s! {
         pub ev: crate::__c_anonymous_struct_ev,
     }
 
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct _sighandler_info {
         pub siginfo: crate::siginfo_t,
         pub handler: Option<unsafe extern "C" fn(value: c_int)>,

src/unix/redox/mod.rs

@@ -157,6 +157,8 @@ s! {
         pub pw_shell: *mut c_char,
     }
 
+    // FIXME(1.0): This should not implement `PartialEq`
+    #[allow(unpredictable_function_pointer_comparisons)]
     pub struct sigaction {
         pub sa_sigaction: crate::sighandler_t,
         pub sa_flags: c_ulong,