Skip to content
This repository was archived by the owner on Apr 28, 2025. It is now read-only.

Commit 4b89115

Browse files
committed
Combine the WASM CI job with the others
There isn't any reason to be distinct here, and it would be better to test with all feature configurations in run.sh anyway.
1 parent 14c7066 commit 4b89115

File tree

2 files changed

+8
-17
lines changed

2 files changed

+8
-17
lines changed

.github/workflows/main.yml

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ env:
99

1010
jobs:
1111
test:
12-
name: Docker
12+
name: Build and test
1313
timeout-minutes: 20
1414
strategy:
1515
fail-fast: false
@@ -52,6 +52,9 @@ jobs:
5252
os: ubuntu-latest
5353
- target: x86_64-apple-darwin
5454
os: macos-13
55+
- target: wasm32-unknown-unknown
56+
os: ubuntu-latest
57+
build_only: 1
5558
- target: i686-pc-windows-msvc
5659
os: windows-latest
5760
- target: x86_64-pc-windows-msvc
@@ -89,30 +92,19 @@ jobs:
8992

9093
# Non-linux tests just use our raw script
9194
- name: Run locally
92-
if: matrix.os != 'ubuntu-latest'
95+
if: matrix.os != 'ubuntu-latest' || contains(matrix.target, 'wasm')
9396
shell: bash
9497
run: ./ci/run.sh ${{ matrix.target }}
9598

9699
# Otherwise we use our docker containers to run builds
97100
- name: Run in Docker
98-
if: matrix.os == 'ubuntu-latest'
101+
if: matrix.os == 'ubuntu-latest' && !contains(matrix.target, 'wasm')
99102
run: |
100103
rustup target add x86_64-unknown-linux-musl
101104
cargo generate-lockfile && ./ci/run-docker.sh ${{ matrix.target }}
102105
103-
wasm:
104-
name: WebAssembly
105-
runs-on: ubuntu-latest
106-
steps:
107-
- uses: actions/checkout@master
108-
- name: Install Rust
109-
run: rustup update nightly --no-self-update && rustup default nightly
110-
- run: rustup target add wasm32-unknown-unknown
111-
- uses: Swatinem/rust-cache@v2
112-
- run: cargo build --target wasm32-unknown-unknown
113-
114106
builtins:
115-
name: "The compiler-builtins crate works"
107+
name: Check use with compiler-builtins
116108
runs-on: ubuntu-latest
117109
steps:
118110
- uses: actions/checkout@master
@@ -164,7 +156,6 @@ jobs:
164156
success:
165157
needs:
166158
- test
167-
- wasm
168159
- builtins
169160
- benchmarks
170161
- msrv

ci/run.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ if [ "${BUILD_ONLY:-}" = "1" ]; then
5555
$cmd
5656
$cmd --features "unstable-intrinsics"
5757

58-
echo "can't run tests on $target"
58+
echo "can't run tests on $target; skipping"
5959
else
6060
cmd="cargo test --all --target $target $extra_flags"
6161

0 commit comments

Comments
 (0)