Skip to content

Commit 67aee5c

Browse files
committed
Switch from rustc_serialize to serde. Closes #18
1 parent 30eb857 commit 67aee5c

File tree

7 files changed

+33
-28
lines changed

7 files changed

+33
-28
lines changed

Cargo.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,9 @@ exclude = [
1616

1717
[dependencies]
1818
clap = "2.2.1"
19-
handlebars = "0.20.0"
20-
rustc-serialize = "0.3.18"
19+
handlebars = { version = "0.20.0", features = ["serde_type"] }
20+
serde = "0.8.17"
21+
serde_json = "0.8.3"
2122
pulldown-cmark = "0.0.8"
2223
log = "0.3"
2324
env_logger = "0.3.4"

src/book/bookconfig.rs

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
use rustc_serialize::json::Json;
1+
use serde_json;
2+
use serde_json::Value;
23
use std::fs::File;
34
use std::io::Read;
45
use std::path::{Path, PathBuf};
@@ -53,23 +54,25 @@ impl BookConfig {
5354
}
5455

5556
// Convert to JSON
56-
if let Ok(config) = Json::from_str(&data) {
57+
if let Ok(config) = serde_json::from_str::<serde_json::Value>(&data) {
5758
// Extract data
5859

60+
let config = config.as_object().unwrap();
61+
5962
debug!("[*]: Extracting data from config");
6063
// Title, author, description
61-
if let Some(a) = config.find_path(&["title"]) {
64+
if let Some(a) = config.get("title") {
6265
self.title = a.to_string().replace("\"", "")
6366
}
64-
if let Some(a) = config.find_path(&["author"]) {
67+
if let Some(a) = config.get("author") {
6568
self.author = a.to_string().replace("\"", "")
6669
}
67-
if let Some(a) = config.find_path(&["description"]) {
70+
if let Some(a) = config.get("description") {
6871
self.description = a.to_string().replace("\"", "")
6972
}
7073

7174
// Destination
72-
if let Some(a) = config.find_path(&["dest"]) {
75+
if let Some(a) = config.get("dest") {
7376
let dest = PathBuf::from(&a.to_string().replace("\"", ""));
7477

7578
// If path is relative make it absolute from the parent directory of src

src/book/bookitem.rs

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
use rustc_serialize::json::{Json, ToJson};
1+
use serde::{Serialize, Serializer};
22
use std::path::PathBuf;
33
use std::collections::BTreeMap;
44

@@ -36,16 +36,12 @@ impl Chapter {
3636
}
3737

3838

39-
impl ToJson for Chapter {
40-
fn to_json(&self) -> Json {
41-
let mut m: BTreeMap<String, Json> = BTreeMap::new();
42-
m.insert("name".to_owned(), self.name.to_json());
43-
m.insert("path".to_owned(),
44-
self.path
45-
.to_str()
46-
.expect("Json conversion failed for path")
47-
.to_json());
48-
m.to_json()
39+
impl Serialize for Chapter {
40+
fn serialize<S>(&self, serializer: &mut S) -> Result<(), S::Error> where S: Serializer {
41+
let mut state = try!(serializer.serialize_struct("Chapter", 2));
42+
try!(serializer.serialize_struct_elt(&mut state, "name", self.name.clone()));
43+
try!(serializer.serialize_struct_elt(&mut state, "path", self.path.clone()));
44+
serializer.serialize_struct_end(state)
4945
}
5046
}
5147

src/lib.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,8 @@
6969
//!
7070
//! Make sure to take a look at it.
7171
72-
extern crate rustc_serialize;
72+
extern crate serde;
73+
extern crate serde_json;
7374
extern crate handlebars;
7475
extern crate pulldown_cmark;
7576

src/renderer/html_handlebars/hbs_renderer.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,10 @@ use std::io::{self, Read, Write};
1111
use std::collections::BTreeMap;
1212

1313
use handlebars::Handlebars;
14-
use rustc_serialize::json::{Json, ToJson};
14+
15+
use serde::Serialize;
16+
use serde_json;
17+
use serde_json::value::ToJson;
1518

1619

1720
pub struct HtmlHandlebars;
@@ -276,10 +279,10 @@ impl Renderer for HtmlHandlebars {
276279
}
277280
}
278281

279-
fn make_data(book: &MDBook) -> Result<BTreeMap<String, Json>, Box<Error>> {
282+
fn make_data(book: &MDBook) -> Result<serde_json::Map<String, serde_json::Value>, Box<Error>> {
280283
debug!("[fn]: make_data");
281284

282-
let mut data = BTreeMap::new();
285+
let mut data = serde_json::Map::new();
283286
data.insert("language".to_owned(), "en".to_json());
284287
data.insert("title".to_owned(), book.get_title().to_json());
285288
data.insert("description".to_owned(), book.get_description().to_json());

src/renderer/html_handlebars/helpers/navigation.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
use std::path::Path;
22
use std::collections::BTreeMap;
33

4-
use rustc_serialize::json::{self, ToJson};
4+
use serde_json;
5+
use serde_json::value::ToJson;
56
use handlebars::{Handlebars, RenderError, RenderContext, Helper, Context, Renderable};
67

78
// Handlebars helper for navigation
@@ -22,7 +23,7 @@ pub fn previous(c: &Context, _h: &Helper, r: &Handlebars, rc: &mut RenderContext
2223

2324
debug!("[*]: Decode chapters from JSON");
2425
// Decode json format
25-
let decoded: Vec<BTreeMap<String, String>> = match json::decode(&chapters.to_string()) {
26+
let decoded: Vec<BTreeMap<String, String>> = match serde_json::from_str(&chapters.to_string()) {
2627
Ok(data) => data,
2728
Err(_) => return Err(RenderError::new("Could not decode the JSON data")),
2829
};
@@ -121,7 +122,7 @@ pub fn next(c: &Context, _h: &Helper, r: &Handlebars, rc: &mut RenderContext) ->
121122

122123
debug!("[*]: Decode chapters from JSON");
123124
// Decode json format
124-
let decoded: Vec<BTreeMap<String, String>> = match json::decode(&chapters.to_string()) {
125+
let decoded: Vec<BTreeMap<String, String>> = match serde_json::from_str(&chapters.to_string()) {
125126
Ok(data) => data,
126127
Err(_) => return Err(RenderError::new("Could not decode the JSON data")),
127128
};

src/renderer/html_handlebars/helpers/toc.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
use std::path::Path;
22
use std::collections::BTreeMap;
33

4-
use rustc_serialize::json;
4+
use serde_json;
55
use handlebars::{Handlebars, HelperDef, RenderError, RenderContext, Helper, Context};
66
use pulldown_cmark::{Parser, html, Event, Tag};
77

@@ -20,7 +20,7 @@ impl HelperDef for RenderToc {
2020
try!(rc.writer.write("<ul class=\"chapter\">".as_bytes()));
2121

2222
// Decode json format
23-
let decoded: Vec<BTreeMap<String, String>> = json::decode(&chapters.to_string()).unwrap();
23+
let decoded: Vec<BTreeMap<String, String>> = serde_json::from_str(&chapters.to_string()).unwrap();
2424

2525
let mut current_level = 1;
2626

0 commit comments

Comments
 (0)