MDBook::build() no longer takes &mut self

Author: Michael-F-Bryan

src/bin/serve.rs

@@ -90,7 +90,7 @@ pub fn execute(args: &ArgMatches) -> Result<()> {
                 b.config.set("output.html.livereload-url", &livereload_url)?;
                 Ok(b)
             })
-            .and_then(|mut b| b.build());
+            .and_then(|b| b.build());
 
         if let Err(e) = result {
             error!("Unable to load the book");

src/bin/watch.rs

@@ -22,7 +22,7 @@ pub fn make_subcommand<'a, 'b>() -> App<'a, 'b> {
 // Watch command implementation
 pub fn execute(args: &ArgMatches) -> Result<()> {
     let book_dir = get_book_dir(args);
-    let mut book = MDBook::load(&book_dir)?;
+    let book = MDBook::load(&book_dir)?;
 
     if args.is_present("open") {
         book.build()?;
@@ -31,7 +31,7 @@ pub fn execute(args: &ArgMatches) -> Result<()> {
 
     trigger_on_change(&book, |path, book_dir| {
         println!("File changed: {:?}\nBuilding book...\n", path);
-        let result = MDBook::load(&book_dir).and_then(|mut b| b.build());
+        let result = MDBook::load(&book_dir).and_then(|b| b.build());
 
         if let Err(e) = result {
             println!("Error while building: {}", e);

src/book/mod.rs

@@ -145,7 +145,7 @@ impl MDBook {
     }
 
     /// Tells the renderer to build our book and put it in the build directory.
-    pub fn build(&mut self) -> Result<()> {
+    pub fn build(&self) -> Result<()> {
         debug!("[fn]: build");
 
         for renderer in &self.renderers {

tests/init.rs

@@ -62,7 +62,7 @@ fn run_mdbook_init_with_custom_book_and_src_locations() {
 #[test]
 fn book_toml_isnt_required() {
     let temp = TempDir::new("mdbook").unwrap();
-    let mut md = MDBook::init(temp.path()).build().unwrap();
+    let md = MDBook::init(temp.path()).build().unwrap();
 
     let _ = fs::remove_file(temp.path().join("book.toml"));
 

tests/rendered_output.rs

@@ -22,7 +22,6 @@ use mdbook::utils::fs::file_to_string;
 use mdbook::config::Config;
 use mdbook::MDBook;
 
-
 const BOOK_ROOT: &'static str = concat!(env!("CARGO_MANIFEST_DIR"), "/tests/dummy_book");
 const TOC_TOP_LEVEL: &[&'static str] = &[
     "1. First Chapter",
@@ -36,15 +35,15 @@ const TOC_SECOND_LEVEL: &[&'static str] = &["1.1. Nested Chapter"];
 #[test]
 fn build_the_dummy_book() {
     let temp = DummyBook::new().build().unwrap();
-    let mut md = MDBook::load(temp.path()).unwrap();
+    let md = MDBook::load(temp.path()).unwrap();
 
     md.build().unwrap();
 }
 
 #[test]
 fn by_default_mdbook_generates_rendered_content_in_the_book_directory() {
     let temp = DummyBook::new().build().unwrap();
-    let mut md = MDBook::load(temp.path()).unwrap();
+    let md = MDBook::load(temp.path()).unwrap();
 
     assert!(!temp.path().join("book").exists());
     md.build().unwrap();
@@ -56,7 +55,7 @@ fn by_default_mdbook_generates_rendered_content_in_the_book_directory() {
 #[test]
 fn make_sure_bottom_level_files_contain_links_to_chapters() {
     let temp = DummyBook::new().build().unwrap();
-    let mut md = MDBook::load(temp.path()).unwrap();
+    let md = MDBook::load(temp.path()).unwrap();
     md.build().unwrap();
 
     let dest = temp.path().join("book");
@@ -78,7 +77,7 @@ fn make_sure_bottom_level_files_contain_links_to_chapters() {
 #[test]
 fn check_correct_cross_links_in_nested_dir() {
     let temp = DummyBook::new().build().unwrap();
-    let mut md = MDBook::load(temp.path()).unwrap();
+    let md = MDBook::load(temp.path()).unwrap();
     md.build().unwrap();
 
     let first = temp.path().join("book").join("first");
@@ -115,7 +114,7 @@ fn check_correct_cross_links_in_nested_dir() {
 #[test]
 fn rendered_code_has_playpen_stuff() {
     let temp = DummyBook::new().build().unwrap();
-    let mut md = MDBook::load(temp.path()).unwrap();
+    let md = MDBook::load(temp.path()).unwrap();
     md.build().unwrap();
 
     let nested = temp.path().join("book/first/nested.html");
@@ -138,7 +137,7 @@ fn chapter_content_appears_in_rendered_document() {
     ];
 
     let temp = DummyBook::new().build().unwrap();
-    let mut md = MDBook::load(temp.path()).unwrap();
+    let md = MDBook::load(temp.path()).unwrap();
     md.build().unwrap();
 
     let destination = temp.path().join("book");
@@ -149,7 +148,6 @@ fn chapter_content_appears_in_rendered_document() {
     }
 }
 
-
 /// Apply a series of predicates to some root predicate, where each
 /// successive predicate is the descendant of the last one. Similar to how you
 /// might do `ul.foo li a` in CSS to access all anchor tags in the `foo` list.
@@ -162,7 +160,6 @@ macro_rules! descendants {
     };
 }
 
-
 /// Make sure that all `*.md` files (excluding `SUMMARY.md`) were rendered
 /// and placed in the `book` directory with their extensions set to `*.html`.
 #[test]
@@ -286,7 +283,7 @@ fn create_missing_file_with_config() {
 #[test]
 fn able_to_include_rust_files_in_chapters() {
     let temp = DummyBook::new().build().unwrap();
-    let mut md = MDBook::load(temp.path()).unwrap();
+    let md = MDBook::load(temp.path()).unwrap();
     md.build().unwrap();
 
     let second = temp.path().join("book/second.html");
@@ -302,7 +299,7 @@ fn able_to_include_rust_files_in_chapters() {
 fn example_book_can_build() {
     let example_book_dir = dummy_book::new_copy_of_example_book().unwrap();
 
-    let mut md = MDBook::load(example_book_dir.path()).unwrap();
+    let md = MDBook::load(example_book_dir.path()).unwrap();
 
     md.build().unwrap();
 }