Skip to content

Readiness to be a dependency for rustc? #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
steveklabnik opened this issue Feb 12, 2016 · 4 comments
Closed

Readiness to be a dependency for rustc? #105

steveklabnik opened this issue Feb 12, 2016 · 4 comments

Comments

@steveklabnik
Copy link
Member

In rust-lang/rust#31590 (comment), we're discussing how to generate the longform docs in the new Cargo-based build system.

Is mdBook up for this yet? I don't have any particular reason why it would not, but figured I'd ask first. 😄

@steveklabnik steveklabnik changed the title Readiness to be moved upstream? Readiness to be a dependency for rustc? Feb 12, 2016
@azerupi
Copy link
Contributor

azerupi commented Feb 12, 2016

I don't have a problem with that, but I would personally recommend to wait until I release 0.1.0

I want to move to a TOML based configuration file, add multilingual support and move optional features to "plugins" that can be enabled through the configuration file. So it will be a "breaking" release.

I assume that being a rustc dependency adds some constraints to breaking changes?
Is there a way to specify specific versions for binaries with cargo install? If there is, it's less of a problem, because you are not bound to the latest release I pushed.

@steveklabnik
Copy link
Member Author

I assume that being a rustc dependency adds some constraints to breaking changes?

Not currently. Almost nothing in the ecosystem is 1.0 in general, so all of the dependencies have breaking changes and get updated whenever someone wants to update them, and then they have to fix it as well.

Is there a way to specify specific versions for binaries with cargo install?

Lots:

Specifying what crate to install:
    --vers VERS               Specify a version to install from crates.io
    --git URL                 Git URL to install the specified crate from
    --branch BRANCH           Branch to use when installing from git
    --tag TAG                 Tag to use when installing from git
    --rev SHA                 Specific commit to use when installing from git
    --path PATH               Filesystem path to local crate to install

because you are not bound to the latest release I pushed.

Ah, well given Cargo.lock, it shouldn't just update itself automatically anyway; we'd be picking a version and upgrading when we plan to like usual.

@azerupi
Copy link
Contributor

azerupi commented Feb 12, 2016

In that case, I don't have any objection.
If you think it is ready enough, that is all that matters :)

@steveklabnik
Copy link
Member Author

Great!

It's not totally clear when the Cargo-based system will actually land, so it might be post-1.0 anyway. Just wanted to hear your thoughts. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants