Skip to content

run fix clippy warnings in the repository #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
budziq opened this issue Aug 10, 2017 · 4 comments
Closed

run fix clippy warnings in the repository #399

budziq opened this issue Aug 10, 2017 · 4 comments
Labels
E-Easy Experience: Easy

Comments

@budziq
Copy link
Contributor

budziq commented Aug 10, 2017

The codebase could use some minor cleanups:
We should run clippy on the codebase and fix its warnings.

It is a nice introductory task to get someones feet wet in the project with some light mentoring.

@budziq budziq added the E-Easy Experience: Easy label Aug 10, 2017
@jacwah
Copy link
Contributor

jacwah commented Oct 9, 2017

Is this resolved by #466?

@azerupi
Copy link
Contributor

azerupi commented Oct 9, 2017

Was that all the clippy warnings?
I am surprised we got so few warnings on the whole code base 😲

@jacwah
Copy link
Contributor

jacwah commented Oct 9, 2017

#466 fixes all but the two warnings I listed. I'm not sure what to do about those, so would love some feedback :)

@azerupi
Copy link
Contributor

azerupi commented Oct 11, 2017

I'm not sure what to do about those, so would love some feedback

I would mark them as allowed (or ignore? whatever clippy understands) on a case by case basis. We should avoid disabling the warning on the whole code base and evaluate every instance as they come.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-Easy Experience: Easy
Projects
None yet
Development

No branches or pull requests

3 participants