Skip to content

Search results drawn on top of the page content #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Michael-F-Bryan opened this issue Mar 15, 2018 · 1 comment
Closed

Search results drawn on top of the page content #643

Michael-F-Bryan opened this issue Mar 15, 2018 · 1 comment

Comments

@Michael-F-Bryan
Copy link
Contributor

I think a recent update to CSS (presumably #638) changed how the search results are placed. If you do a search on the User Guide you'll see the search results being rendered directly on top of the page contents.

I'm assuming this issue crept in because I'd looked at #638 locally in the past, but then merged #604 without checking to make sure #638 was still okay.

image

I'm not a CSS expert, but I believe the issue is because the search results (id=searchresults-outer) is display: block, while the page contents (id=content) is positioned using absolute coordinates. If you close the sidebar, the page gets rendered just fine again.

CC: @GuillaumeGomez, @mattico


We're lucky I noticed this before making a big announcement on Reddit. Looking at the crates.io stats, it seems like only 65 people have downloaded v0.1.4 so far, two of which are from me.

@GuillaumeGomez
Copy link
Member

I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants