Skip to content

Test libstd backtrace type #1578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
RalfJung opened this issue Oct 8, 2020 · 2 comments · Fixed by #1584
Closed

Test libstd backtrace type #1578

RalfJung opened this issue Oct 8, 2020 · 2 comments · Fixed by #1584
Labels
A-shims Area: This affects the external function shims C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement

Comments

@RalfJung
Copy link
Member

RalfJung commented Oct 8, 2020 •
edited
Loading

@Aaron1011 added support for capturing backtraces in Miri, but so far we only test directly using the Miri API for that. Once actually using the libstd types works, we should test those as well.

@Aaron1011 what is the status of that?
@RalfJung RalfJung added C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement A-shims Area: This affects the external function shims labels Oct 8, 2020
@Aaron1011
Copy link
Member

Aaron1011 commented Oct 8, 2020 •
edited
Loading

I think we need to bump the backtrace-rs submodule in libstd.

@Aaron1011
Copy link
Member

This is being done in rust-lang/rust#77731

@cuviper cuviper mentioned this issue Oct 10, 2020
Closed
Aaron1011 added a commit to Aaron1011/miri that referenced this issue Oct 17, 2020
@Aaron1011
Test std::backtrace::Backtrace
13c8b79 
Fixes rust-lang#1578
@RalfJung RalfJung mentioned this issue Oct 18, 2020
Merged
bors added a commit that referenced this issue Oct 18, 2020
@bors
Auto merge of #1584 - Aaron1011:test/std-backtrace, r=RalfJung
4ad1667 
Test std backtrace type

Closes #1578
@bors bors closed this as completed in 8b10dbf Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-shims Area: This affects the external function shims C-enhancement Category: a PR with an enhancement or an issue tracking an accepted enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test std backtrace type Aaron1011/miri
2 participants
@RalfJung @Aaron1011