Skip to content

Miri fail to build on current master #4339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tiif opened this issue May 21, 2025 · 4 comments
Closed

Miri fail to build on current master #4339

tiif opened this issue May 21, 2025 · 4 comments

Comments

@tiif
Copy link
Contributor

tiif commented May 21, 2025

On current master 2dbc4a2cf, ./miri build will emit

error[E0658]: `let` expressions in this position are unstable
   --> miri-script/src/commands.rs:678:20
    |
678 |         if !dep && let Some(target) = &target {
    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information
    = help: add `#![feature(let_chains)]` to the crate attributes to enable
    = note: this compiler was built on 2025-03-05; consider upgrading it if it is out of date

error[E0658]: `let` expressions in this position are unstable
   --> miri-script/src/commands.rs:708:19
    |
708 |         if dep && let Some(target) = &target {
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: see issue #53667 <https://github.com/rust-lang/rust/issues/53667> for more information
    = help: add `#![feature(let_chains)]` to the crate attributes to enable
    = note: this compiler was built on 2025-03-05; consider upgrading it if it is out of date

For more information about this error, try `rustc --explain E0658`.
error: could not compile `miri-script` (bin "miri-script") due to 2 previous errors
Failed to build miri-script. Is the 'nightly' toolchain installed?

These changes are from #4324. On first glance, we probably need to update our compiler version?

@tiif
Copy link
Contributor Author

tiif commented May 21, 2025

This is weird, maybe there are some problems with my local config?

@oli-obk
Copy link
Contributor

oli-obk commented May 21, 2025

miri only ever builds with the rustc version defined in https://github.com/rust-lang/miri/blob/master/rust-version

you may need to set it up again https://github.com/rust-lang/miri/blob/master/CONTRIBUTING.md#preparing-the-build-environment

@oli-obk
Copy link
Contributor

oli-obk commented May 21, 2025

ah miri-script gets built with nightly, so you may have to install/update that via rustup

@tiif
Copy link
Contributor Author

tiif commented May 21, 2025

Yup rustup update works, thanks!

@tiif tiif closed this as completed May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants