Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

SymbolInformation should not return local variables #594

Closed
Yanpas opened this issue Nov 24, 2017 · 1 comment
Closed

SymbolInformation should not return local variables #594

Yanpas opened this issue Nov 24, 2017 · 1 comment

Comments

@Yanpas
Copy link

Yanpas commented Nov 24, 2017

Currently document::SymbolInformation returns local variables too. SymbolInformation is used for building outline and local variables are unnecessary there.
@aldonogueira aldonogueira mentioned this issue Feb 25, 2018
Closed
aldonogueira added a commit to aldonogueira/rls that referenced this issue Feb 25, 2018
@aldonogueira
Removes local variables from outline rust-lang#594
1563279
aldonogueira added a commit to aldonogueira/rls that referenced this issue Feb 25, 2018
@aldonogueira
Removes local variables from outline rust-lang#594
fb073a5
aldonogueira added a commit to aldonogueira/rls that referenced this issue Feb 27, 2018
@aldonogueira
Revert "Removes local variables from outline rust-lang#594"
2c3b827 
This reverts commit fb073a5.
aldonogueira added a commit to aldonogueira/rls that referenced this issue Feb 27, 2018
@aldonogueira
New mapping from RLS kind to LSP kind rust-lang#594
fe88c7b 
Changes:
  Union -> Enum,
  Method -> Method,
  Field -> Field,
  Static and Const -> Constant,
  TupleVariant and StructVariant -> Field.
Leaving Variable only for local variables.
Comment for future update to LSP 3.
nrc added a commit that referenced this issue Mar 2, 2018
@nrc
Merge pull request #734 from aldonogueira/master
40d6b7b 
Removes local variables from outline #594
@Yanpas
Copy link
Author

Yanpas commented Mar 3, 2018

Closed by merge #734

@Yanpas Yanpas closed this as completed Mar 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Yanpas