Skip to content

Commit 9bd8336

Browse files
committed
Remove LocalEdit usage
1 parent 58e7766 commit 9bd8336

File tree

2 files changed

+17
-16
lines changed

2 files changed

+17
-16
lines changed

crates/ra_ide_api/src/join_lines.rs

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
use itertools::Itertools;
2+
use ra_db::FileRange;
23
use ra_syntax::{
34
SourceFile, TextRange, TextUnit, AstNode, SyntaxNode,
45
SyntaxKind::{self, WHITESPACE, COMMA, R_CURLY, R_PAREN, R_BRACK},
@@ -9,26 +10,19 @@ use ra_syntax::{
910
use ra_fmt::{
1011
compute_ws, extract_trivial_expression
1112
};
12-
use ra_text_edit::TextEditBuilder;
13-
use ra_ide_api_light::LocalEdit;
13+
use ra_text_edit::{TextEdit, TextEditBuilder};
1414

15-
pub fn join_lines(file: &SourceFile, range: TextRange) -> LocalEdit {
16-
let range = if range.is_empty() {
15+
pub fn join_lines(file: &SourceFile, frange: FileRange) -> TextEdit {
16+
let range = if frange.range.is_empty() {
1717
let syntax = file.syntax();
18-
let text = syntax.text().slice(range.start()..);
18+
let text = syntax.text().slice(frange.range.start()..);
1919
let pos = match text.find('\n') {
20-
None => {
21-
return LocalEdit {
22-
label: "join lines".to_string(),
23-
edit: TextEditBuilder::default().finish(),
24-
cursor_position: None,
25-
};
26-
}
20+
None => return TextEditBuilder::default().finish(),
2721
Some(pos) => pos,
2822
};
29-
TextRange::offset_len(range.start() + pos, TextUnit::of_char('\n'))
23+
TextRange::offset_len(frange.range.start() + pos, TextUnit::of_char('\n'))
3024
} else {
31-
range
25+
frange.range
3226
};
3327

3428
let node = find_covering_node(file.syntax(), range);
@@ -51,7 +45,7 @@ pub fn join_lines(file: &SourceFile, range: TextRange) -> LocalEdit {
5145
}
5246
}
5347

54-
LocalEdit { label: "join lines".to_string(), edit: edit.finish(), cursor_position: None }
48+
edit.finish()
5549
}
5650

5751
fn remove_newline(

crates/ra_ide_api/src/lib.rs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,14 @@ impl Analysis {
279279
/// stuff like trailing commas.
280280
pub fn join_lines(&self, frange: FileRange) -> SourceChange {
281281
let file = self.db.parse(frange.file_id);
282-
SourceChange::from_local_edit(frange.file_id, join_lines::join_lines(&file, frange.range))
282+
let file_edit =
283+
SourceFileEdit { file_id: frange.file_id, edit: join_lines::join_lines(&file, frange) };
284+
SourceChange {
285+
label: "join lines".to_string(),
286+
source_file_edits: vec![file_edit],
287+
file_system_edits: vec![],
288+
cursor_position: None,
289+
}
283290
}
284291

285292
/// Returns an edit which should be applied when opening a new line, fixing

0 commit comments

Comments
 (0)