Skip to content

Commit b0c7ff3

Browse files
committed
remove one need for semantics
1 parent 54fc989 commit b0c7ff3

File tree

2 files changed

+9
-13
lines changed

2 files changed

+9
-13
lines changed

crates/ide/src/navigation_target.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -169,9 +169,8 @@ impl NavigationTarget {
169169

170170
impl TryToNav for FileSymbol {
171171
fn try_to_nav(&self, db: &RootDatabase) -> Option<NavigationTarget> {
172-
let semantics = Semantics::new(db);
173-
let full_range = self.loc.original_range(&semantics)?;
174-
let name_range = self.loc.original_name_range(&semantics)?;
172+
let full_range = self.loc.original_range(db)?;
173+
let name_range = self.loc.original_name_range(db)?;
175174

176175
Some(NavigationTarget {
177176
file_id: full_range.file_id,

crates/ide_db/src/symbol_index.rs

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -382,28 +382,25 @@ impl DeclarationLocation {
382382
Some(self.ptr.to_node(&root))
383383
}
384384

385-
pub fn original_range(&self, semantics: &Semantics<'_, RootDatabase>) -> Option<FileRange> {
386-
find_original_file_range(semantics, self.hir_file_id, &self.ptr)
385+
pub fn original_range(&self, db: &dyn HirDatabase) -> Option<FileRange> {
386+
find_original_file_range(db, self.hir_file_id, &self.ptr)
387387
}
388388

389-
pub fn original_name_range(
390-
&self,
391-
semantics: &Semantics<'_, RootDatabase>,
392-
) -> Option<FileRange> {
393-
find_original_file_range(semantics, self.hir_file_id, &self.name_ptr)
389+
pub fn original_name_range(&self, db: &dyn HirDatabase) -> Option<FileRange> {
390+
find_original_file_range(db, self.hir_file_id, &self.name_ptr)
394391
}
395392
}
396393

397394
fn find_original_file_range(
398-
semantics: &Semantics<'_, RootDatabase>,
395+
db: &dyn HirDatabase,
399396
file_id: HirFileId,
400397
ptr: &SyntaxNodePtr,
401398
) -> Option<FileRange> {
402-
let root = semantics.parse_or_expand(file_id)?;
399+
let root = db.parse_or_expand(file_id)?;
403400
let node = ptr.to_node(&root);
404401
let node = InFile::new(file_id, &node);
405402

406-
Some(node.original_file_range(semantics.db.upcast()))
403+
Some(node.original_file_range(db.upcast()))
407404
}
408405

409406
#[derive(PartialEq, Eq, Hash, Clone, Copy, Debug)]

0 commit comments

Comments
 (0)