Merge #11106

11106: internal: Remove network access from Code extension r=lnicola a=lnicola



Co-authored-by: Laurențiu Nicola <[email protected]>

Author: bors[bot]

PRIVACY.md

@@ -1 +1 @@
-See the [Privacy](https://rust-analyzer.github.io/manual.html#security) section of the user manual.
+See the [Privacy](https://rust-analyzer.github.io/manual.html#privacy) section of the user manual.

docs/user/manual.adoc

@@ -653,10 +653,12 @@ Here is a **non-exhaustive** list of ways to make rust-analyzer execute arbitrar
 The LSP server performs no network access in itself, but runs `cargo metadata` which will update or download the crate registry and the source code of the project dependencies.
 If enabled (the default), build scripts and procedural macros can do anything.
 
-The Code extension automatically connects to GitHub to download updated LSP binaries and, if the nightly channel is selected, to perform update checks using the GitHub API. For `rust-analyzer` developers, using `cargo xtask release` uses the same API to put together the release notes.
+The Code extension does not access the network.
 
 Any other editor plugins are not under the control of the `rust-analyzer` developers. For any privacy concerns, you should check with their respective developers.
 
+For `rust-analyzer` developers, `cargo xtask release` uses the GitHub API to put together the release notes.
+
 == Features
 
 include::./generated_features.adoc[]

editors/code/package-lock.json

@@ -36,8 +36,6 @@
         "test": "node ./out/tests/runTests.js"
     },
     "dependencies": {
-        "https-proxy-agent": "^5.0.0",
-        "node-fetch": "^3.0.3",
         "vscode-languageclient": "8.0.0-next.2",
         "d3": "^7.2.0",
         "d3-graphviz": "^4.0.0"
@@ -305,24 +303,6 @@
                     "default": true,
                     "description": "Whether inlay hints font size should be smaller than editor's font size."
                 },
-                "rust-analyzer.updates.channel": {
-                    "type": "string",
-                    "enum": [
-                        "stable",
-                        "nightly"
-                    ],
-                    "default": "stable",
-                    "markdownEnumDescriptions": [
-                        "`stable` updates are shipped weekly, they don't contain cutting-edge features from VSCode proposed APIs but have less bugs in general.",
-                        "`nightly` updates are shipped daily (extension updates automatically by downloading artifacts directly from GitHub), they contain cutting-edge features and latest bug fixes. These releases help us get your feedback very quickly and speed up rust-analyzer development **drastically**."
-                    ],
-                    "markdownDescription": "Choose `nightly` updates to get the latest features and bug fixes every day. While `stable` releases occur weekly and don't contain cutting-edge features from VSCode proposed APIs."
-                },
-                "rust-analyzer.updates.askBeforeDownload": {
-                    "type": "boolean",
-                    "default": false,
-                    "description": "Whether to ask for permission before downloading any files from the Internet."
-                },
                 "rust-analyzer.server.path": {
                     "type": [
                         "null",

editors/code/package.json

@@ -8,11 +8,6 @@ const NIGHTLY_TAG = "nightly";
 
 export type RunnableEnvCfg = undefined | Record<string, string> | { mask?: string; env: Record<string, string> }[];
 
-export class ProxySettings {
-    proxy?: string = undefined;
-    strictSSL: boolean = true;
-}
-
 export class Config {
     readonly extensionId = "matklad.rust-analyzer";
 
@@ -24,7 +19,6 @@ export class Config {
         "procMacro",
         "files",
         "highlighting",
-        "updates.channel",
         "lens", // works as lens.*
     ]
         .map(opt => `${this.rootSection}.${opt}`);
@@ -36,11 +30,9 @@ export class Config {
     } = vscode.extensions.getExtension(this.extensionId)!.packageJSON;
 
     readonly globalStorageUri: vscode.Uri;
-    readonly installUri: vscode.Uri;
 
     constructor(ctx: vscode.ExtensionContext) {
         this.globalStorageUri = ctx.globalStorageUri;
-        this.installUri = ctx.extensionUri;
         vscode.workspace.onDidChangeConfiguration(this.onDidChangeConfiguration, this, ctx.subscriptions);
         this.refreshLogging();
     }
@@ -103,21 +95,7 @@ export class Config {
         return this.get<null | string>("server.path") ?? this.get<null | string>("serverPath");
     }
     get serverExtraEnv() { return this.get<Env | null>("server.extraEnv") ?? {}; }
-    get channel() { return this.get<UpdatesChannel>("updates.channel"); }
-    get askBeforeDownload() { return this.get<boolean>("updates.askBeforeDownload"); }
     get traceExtension() { return this.get<boolean>("trace.extension"); }
-    get proxySettings(): ProxySettings {
-        const proxy = vscode
-            .workspace
-            .getConfiguration('http')
-            .get<null | string>("proxy")! || process.env["https_proxy"] || process.env["HTTPS_PROXY"];
-        const strictSSL = vscode.workspace.getConfiguration("http").get<boolean>("proxyStrictSSL") ?? true;
-
-        return {
-            proxy: proxy,
-            strictSSL: strictSSL,
-        };
-    }
 
     get inlayHints() {
         return {