Skip to content

Commit d5b1ae6

Browse files
Remove check_merge_commits test altogether
Rationale: Merge commits will probably end up in `rust-lang/rust-analyzer` when doing "rust=>ra" syncs anyway. It could be changed to only check for merge commits in non-sync PRs, but it's "probably not worth the hassle"
1 parent c520408 commit d5b1ae6

File tree

1 file changed

+0
-51
lines changed
  • crates/rust-analyzer/tests/slow-tests

1 file changed

+0
-51
lines changed

crates/rust-analyzer/tests/slow-tests/tidy.rs

Lines changed: 0 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -142,57 +142,6 @@ fn check_cargo_toml(path: &Path, text: String) {
142142
}
143143
}
144144

145-
#[cfg(not(feature = "in-rust-tree"))]
146-
#[test]
147-
fn check_merge_commits() {
148-
let sh = &Shell::new().unwrap();
149-
150-
let bors = cmd!(sh, "git rev-list --merges --author 'bors' HEAD~19..").read().unwrap();
151-
let all = cmd!(sh, "git rev-list --merges HEAD~19..").read().unwrap();
152-
if bors != all {
153-
panic!(
154-
"
155-
Merge commits are not allowed in the history.
156-
157-
When updating a pull-request, please rebase your feature branch
158-
on top of master by running `git rebase master`. If rebase fails,
159-
you can re-apply your changes like this:
160-
161-
# Just look around to see the current state.
162-
$ git status
163-
$ git log
164-
165-
# Abort in-progress rebase and merges, if any.
166-
$ git rebase --abort
167-
$ git merge --abort
168-
169-
# Make the branch point to the latest commit from master,
170-
# while maintaining your local changes uncommited.
171-
$ git reset --soft origin/master
172-
173-
# Commit all changes in a single batch.
174-
$ git commit -am'My changes'
175-
176-
# Verify that everything looks alright.
177-
$ git status
178-
$ git log
179-
180-
# Push the changes. We did a rebase, so we need `--force` option.
181-
# `--force-with-lease` is a more safe (Rusty) version of `--force`.
182-
$ git push --force-with-lease
183-
184-
# Verify that both local and remote branch point to the same commit.
185-
$ git log
186-
187-
And don't fear to mess something up during a rebase -- you can
188-
always restore the previous state using `git ref-log`:
189-
190-
https://github.blog/2015-06-08-how-to-undo-almost-anything-with-git/#redo-after-undo-local
191-
"
192-
);
193-
}
194-
}
195-
196145
fn deny_clippy(path: &Path, text: &str) {
197146
let ignore = &[
198147
// The documentation in string literals may contain anything for its own purposes

0 commit comments

Comments
 (0)