Skip to content

Commit e1b7d77

Browse files
authored
Merge pull request #18714 from Veykril/push-krxvsqwrokwp
fix: Do not ask the client to resolve for non existing label details
2 parents d7fa33e + 683150f commit e1b7d77

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

crates/rust-analyzer/src/lsp/to_proto.rs

+4-2
Original file line numberDiff line numberDiff line change
@@ -372,9 +372,11 @@ fn completion_item(
372372
};
373373

374374
if config.completion_label_details_support() {
375+
let has_label_details =
376+
item.label.detail_left.is_some() || item.label.detail_left.is_some();
375377
if fields_to_resolve.resolve_label_details {
376-
something_to_resolve |= true;
377-
} else if item.label.detail_left.is_some() || item.label.detail_left.is_some() {
378+
something_to_resolve |= has_label_details;
379+
} else if has_label_details {
378380
lsp_item.label_details = Some(lsp_types::CompletionItemLabelDetails {
379381
detail: item.label.detail_left.clone(),
380382
description: item.label.detail_right.clone(),

0 commit comments

Comments
 (0)