Skip to content

relevant_parmas_and_where_clauses is dangling #14567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsoref opened this issue Apr 14, 2023 · 3 comments · Fixed by #14577
Closed

relevant_parmas_and_where_clauses is dangling #14567

jsoref opened this issue Apr 14, 2023 · 3 comments · Fixed by #14577

Comments

@jsoref
Copy link
Contributor

jsoref commented Apr 14, 2023

rust-analyzer/crates/ide-assists/src/handlers/generate_function.rs

Line 896 in 2c251a7

// insertion (see `relevant_parmas_and_where_clauses()`).

It was introduced in #14065 in 3edde6f#diff-e36280c9e19413d3eab3f92468e2cd3a9798708843c568a8b6f7a184b5d6c129R881

I can't figure out what it's trying to say.
@lnicola
Copy link
Member

lnicola commented Apr 14, 2023

fn_generic_params or filter_unnecessary_bounds, I suspect.

@lowr
Copy link
Contributor

lowr commented Apr 14, 2023 •
edited
Loading

That's former name of params_and_where_preds_in_scope(), apparently I forgot to update the comment when I renamed that function. Sorry for the confusion!

@jsoref
Copy link
Contributor Author

jsoref commented Apr 14, 2023

The typo of params is probably why the rename failed here.

I might have time to bundle this into a PR today...

@jsoref jsoref mentioned this issue Apr 14, 2023
Merged
@bors bors closed this as completed in 2400b36 Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Spelling jsoref/rust-analyzer
3 participants
@lnicola @jsoref @lowr